From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:54009 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754260AbeGJNYR (ORCPT ); Tue, 10 Jul 2018 09:24:17 -0400 Date: Tue, 10 Jul 2018 21:24:14 +0800 From: kbuild test robot To: Gu Jinxiang Cc: kbuild-all@01.org, linux-btrfs@vger.kernel.org, nborisov@suse.com Subject: [PATCH] btrfs: fix ptr_ret.cocci warnings Message-ID: <20180710132414.GA25686@athens> References: <1531218442-12885-2-git-send-email-gujx@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1531218442-12885-2-git-send-email-gujx@cn.fujitsu.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: From: kbuild test robot fs/btrfs/super.c:2243:8-14: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 193ea416dc5e ("btrfs: get fs_devices pointer form btrfs_scan_one_device") CC: Gu Jinxiang Signed-off-by: kbuild test robot --- super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -2240,7 +2240,7 @@ static long btrfs_control_ioctl(struct f case BTRFS_IOC_SCAN_DEV: fs_devices = btrfs_scan_one_device(vol->name, FMODE_READ, &btrfs_root_fs_type); - ret = IS_ERR(fs_devices) ? PTR_ERR(fs_devices) : 0; + ret = PTR_ERR_OR_ZERO(fs_devices); break; case BTRFS_IOC_DEVICES_READY: fs_devices = btrfs_scan_one_device(vol->name, FMODE_READ,