From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Introduce compile time structure size check
Date: Fri, 13 Jul 2018 16:34:18 +0200 [thread overview]
Message-ID: <20180713143418.GW3126@twin.jikos.cz> (raw)
In-Reply-To: <20180712061907.24783-1-wqu@suse.com>
On Thu, Jul 12, 2018 at 02:19:07PM +0800, Qu Wenruo wrote:
> Introduce a new macro based compile time check for ioctl structures.
>
> The new macro is BTRFS_ASSERT_SIZE(), which is mostly copied from
> VMMDEV_ASSERT_SIZE().
The macro should be generic, there's nothing specific to btrfs. There's
a similar one in the progs.
> Such check is only added to structure pended to power of 2.
There's no constraint about power of 2 sizes, it works for any size.
> And exposed one structure, btrfs_ioctl_get_dev_stats() is not aligned
> well.
> The misalign is introduced by commit b27f7c0c150f ("btrfs: join DEV_STATS
> ioctls to one").
Yeah, that was an oversight, so the correct value to check against is
1024 + 8 = 1032, see ioctl.h in progs.
next prev parent reply other threads:[~2018-07-13 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 6:19 [PATCH] btrfs: Introduce compile time structure size check Qu Wenruo
2018-07-12 6:27 ` Nikolay Borisov
2018-07-12 6:56 ` Qu Wenruo
2018-07-13 14:34 ` David Sterba
2018-07-13 14:34 ` David Sterba [this message]
2018-07-13 14:36 ` Qu Wenruo
2018-07-13 14:46 ` David Sterba
2018-07-13 14:57 ` Qu Wenruo
2018-07-13 15:25 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713143418.GW3126@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox