From: Adam Borowski <kilobyte@angband.pl>
To: David Sterba <dsterba@suse.cz>, Mark Fasheh <mfasheh@suse.de>,
linux-btrfs@vger.kernel.org
Cc: Adam Borowski <kilobyte@angband.pl>
Subject: [PATCH resend 2/2] btrfs: defrag: return EPERM not EINVAL when only permissions fail
Date: Wed, 18 Jul 2018 00:09:00 +0200 [thread overview]
Message-ID: <20180717220900.3588-2-kilobyte@angband.pl> (raw)
In-Reply-To: <20180717220900.3588-1-kilobyte@angband.pl>
We give EINVAL when the request is invalid; here it's ok but merely the
user has insufficient privileges. Thus, this return value reflects the
error better -- as discussed in the identical case for dedupe.
According to codesearch.debian.net, no userspace program distinguishes
these values beyond strerror().
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
fs/btrfs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 01c150b6ab62..e96e3c3caca1 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -2943,7 +2943,7 @@ static int btrfs_ioctl_defrag(struct file *file, void __user *argp)
case S_IFREG:
if (!capable(CAP_SYS_ADMIN) &&
inode_permission(inode, MAY_WRITE)) {
- ret = -EINVAL;
+ ret = -EPERM;
goto out;
}
--
2.18.0
next prev parent reply other threads:[~2018-07-17 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 22:05 [PATCH resend 0/2] btrfs: fix races between exec and defrag Adam Borowski
2018-07-17 22:08 ` [PATCH resend 1/2] btrfs: allow defrag on a file opened ro that has rw permissions Adam Borowski
2018-07-17 22:09 ` Adam Borowski [this message]
2018-07-23 15:26 ` David Sterba
2018-07-24 20:35 ` Adam Borowski
2018-08-01 13:03 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717220900.3588-2-kilobyte@angband.pl \
--to=kilobyte@angband.pl \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=mfasheh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).