From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 3/4] btrfs: bug_on for num_devices below 0
Date: Thu, 26 Jul 2018 14:53:33 +0800 [thread overview]
Message-ID: <20180726065334.30594-4-anand.jain@oracle.com> (raw)
In-Reply-To: <20180726065334.30594-1-anand.jain@oracle.com>
In preparation to add helper function to deduce the num_devices with
replace running, use bug_on instead of warn_on. In btrfs_rm_device()
the check for min devices happens in btrfs_check_raid_min_devices()
but its after its been decremented so a check here is better.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/volumes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index c62b5e46792e..fe74fefc75f7 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -1868,7 +1868,7 @@ int btrfs_rm_device(struct btrfs_fs_info *fs_info, const char *device_path,
num_devices = fs_devices->num_devices;
btrfs_dev_replace_read_lock(&fs_info->dev_replace);
if (btrfs_dev_replace_is_ongoing(&fs_info->dev_replace)) {
- WARN_ON(num_devices < 1);
+ BUG_ON(num_devices < 1);
num_devices--;
}
btrfs_dev_replace_read_unlock(&fs_info->dev_replace);
--
2.7.0
next prev parent reply other threads:[~2018-07-26 8:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 6:53 [PATCH v2 0/4] Misc volume patch set part2 Anand Jain
2018-07-26 6:53 ` [PATCH v4 1/4] btrfs: drop uuid_mutex in btrfs_free_extra_devids() Anand Jain
2018-07-26 6:53 ` [PATCH v2 2/4] btrfs: fix race between free_stale_devices and close_fs_devices Anand Jain
2018-08-01 14:29 ` David Sterba
2018-08-02 9:29 ` Anand Jain
2018-08-07 14:59 ` David Sterba
2018-08-08 9:51 ` Anand Jain
2018-07-26 6:53 ` Anand Jain [this message]
2018-07-26 6:53 ` [PATCH v2 4/4] btrfs: add helper btrfs_num_devices() to deduce num_devices Anand Jain
2018-08-01 14:41 ` David Sterba
2018-08-02 10:09 ` Anand Jain
2018-08-02 10:09 ` [PATCH v3 " Anand Jain
2018-08-02 10:11 ` Nikolay Borisov
2018-08-02 12:21 ` David Sterba
2018-08-02 13:07 ` Anand Jain
2018-08-07 15:02 ` David Sterba
2018-08-07 22:43 ` Anand Jain
2018-08-03 12:45 ` [PATCH v4 " Anand Jain
2018-08-03 12:45 ` [PATCH] btrfs: handle the BUG_ON in btrfs_num_devices() Anand Jain
2018-08-03 13:33 ` Nikolay Borisov
2018-08-06 8:57 ` Anand Jain
2018-08-07 17:09 ` David Sterba
2018-08-07 22:51 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726065334.30594-4-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).