From: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: <clm@fb.com>, <jbacik@fb.com>, <dsterba@suse.com>,
<linux-btrfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] btrfs/extent_map: Remove unneeded variable "ret"
Date: Sun, 5 Aug 2018 00:35:48 +0800 [thread overview]
Message-ID: <20180804163548.GG2049@fnst.localdomain> (raw)
In-Reply-To: <5B65A7E9.90607@huawei.com>
On Sat, Aug 04, 2018 at 09:19:37PM +0800, zhong jiang wrote:
>On 2018/8/4 20:59, Lu Fengqi wrote:
>> On Sat, Aug 04, 2018 at 07:13:43PM +0800, zhong jiang wrote:
>>> The ret is not used after initalization, So just remove it.
>> So why not change these two functions to void function?
>>
> I just keep the original interface and make the minimal change.
>of course, It is also feasible that make these two functions to void function.
>
>I will repost if you prefer to that change. I am ok with that.
Since the return value which always is 0 is meaningless, I would prefer
to make this change.
--
Thanks,
Lu
>
>Thanks,
>zhong jiang
>
>
>
prev parent reply other threads:[~2018-08-04 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 11:13 [PATCH] btrfs/extent_map: Remove unneeded variable "ret" zhong jiang
2018-08-04 12:29 ` Su Yue
2018-08-04 12:59 ` Lu Fengqi
2018-08-04 13:19 ` zhong jiang
2018-08-04 16:35 ` Lu Fengqi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180804163548.GG2049@fnst.localdomain \
--to=lufq.fnst@cn.fujitsu.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox