From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:40786 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbeHNVwm (ORCPT ); Tue, 14 Aug 2018 17:52:42 -0400 Received: by mail-pg1-f193.google.com with SMTP id x5-v6so9513640pgp.7 for ; Tue, 14 Aug 2018 12:04:07 -0700 (PDT) Date: Tue, 14 Aug 2018 12:04:05 -0700 From: Omar Sandoval To: David Sterba Cc: Filipe Manana , linux-btrfs Subject: Re: [PATCH 2/2] Btrfs: sync log after logging new name Message-ID: <20180814190405.GA10954@vader> References: <20180611182428.18102-1-fdmanana@kernel.org> <20180615155428.GG24375@twin.jikos.cz> <20180618110616.GI24375@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180618110616.GI24375@twin.jikos.cz> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Mon, Jun 18, 2018 at 01:06:16PM +0200, David Sterba wrote: > On Fri, Jun 15, 2018 at 05:19:07PM +0100, Filipe Manana wrote: > > On Fri, Jun 15, 2018 at 4:54 PM, David Sterba wrote: > > > On Mon, Jun 11, 2018 at 07:24:28PM +0100, fdmanana@kernel.org wrote: > > >> From: Filipe Manana > > >> Fixes: 12fcfd22fe5b ("Btrfs: tree logging unlink/rename fixes") > > >> Reported-by: Vijay Chidambaram > > >> Signed-off-by: Filipe Manana > > > > > > There are some warnings and possible lock up caused by this patch, the > > > 1/2 alone is ok but 1/2 + 2/2 leads to the following warnings. I checked > > > twice, the patch base was the pull request ie. without any other 4.18 > > > stuff. > > > > Are you sure it's this patch? > > On top of for-4.18 it didn't cause any problems here, plus the trace > > below has nothing to do with renames, hard links or fsync at all - > > everything seems stuck on waiting for IO from dev replace. > > It was a false alert, sorry. Strange that the warnings appeared only in > the VM running both patches and not otherwise. > > Though the test did not directly use rename, the possible error scenario > I had in mind was some leftover from locking, error handling or state > that blocked umount of 011. Dave, are you sending this in for 4.19? I don't see it in your first pull request.