Re: [PATCH 30/35] btrfs: cleanup pending bgs on transaction abort

Omar Sandoval
2018-09-01T04:45:01Z

On Thu, Aug 30, 2018 at 01:42:20PM -0400, Josef Bacik wrote:
> We may abort the transaction during a commit and not have a chance to
> run the pending bgs stuff, which will leave block groups on our list and
> cause us accounting issues and leaked memory. Fix this by running the
> pending bgs when we cleanup a transaction.

Reviewed-by: Omar Sandoval <osandov@fb.com>

Again, I think it's fine to reuse the same function as long as there's a
comment here.

> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> fs/btrfs/transaction.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> index 89d14f135837..0f39a0d302d3 100644
> --- a/fs/btrfs/transaction.c
> +++ b/fs/btrfs/transaction.c
> @@ -2273,6 +2273,7 @@ int btrfs_commit_transaction(struct btrfs_trans_handle *trans)
> btrfs_scrub_continue(fs_info);
> cleanup_transaction:
> btrfs_trans_release_metadata(trans);
> + btrfs_create_pending_block_groups(trans);
> btrfs_trans_release_chunk_metadata(trans);
> trans->block_rsv = NULL;
> btrfs_warn(fs_info, "Skipping commit of aborted transaction.");
> --
> 2.14.3
>