Re: [PATCH 08/35] btrfs: release metadata before running delayed refs

Omar Sandoval
2018-09-01T04:22:13Z

On Thu, Aug 30, 2018 at 01:41:58PM -0400, Josef Bacik wrote:
> We want to release the unused reservation we have since it refills the
> delayed refs reserve, which will make everything go smoother when
> running the delayed refs if we're short on our reservation.

Reviewed-by: Omar Sandoval <osandov@fb.com>

> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> fs/btrfs/transaction.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> index 99741254e27e..ebb0c0405598 100644
> --- a/fs/btrfs/transaction.c
> +++ b/fs/btrfs/transaction.c
> @@ -1915,6 +1915,9 @@ int btrfs_commit_transaction(struct btrfs_trans_handle *trans)
> return ret;
> }
>
> + btrfs_trans_release_metadata(trans);
> + trans->block_rsv = NULL;
> +
> /* make a pass through all the delayed refs we have so far
> * any runnings procs may add more while we are here
> */
> @@ -1924,9 +1927,6 @@ int btrfs_commit_transaction(struct btrfs_trans_handle *trans)
> return ret;
> }
>
> - btrfs_trans_release_metadata(trans);
> - trans->block_rsv = NULL;
> -
> cur_trans = trans->transaction;
>
> /*
> --
> 2.14.3
>