From: Josef Bacik <josef@toxicpanda.com>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Liu Bo <bo.liu@linux.alibaba.com>,
linux-btrfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH] Btrfs: do not wait after queue async work for delaye refs
Date: Wed, 12 Sep 2018 09:54:25 -0400 [thread overview]
Message-ID: <20180912135423.fgl7gbc5lx447h4n@destiny> (raw)
In-Reply-To: <feaa2619-fdb3-efa3-4e2f-878cd81058c1@suse.com>
On Wed, Sep 12, 2018 at 10:19:23AM +0300, Nikolay Borisov wrote:
> [Adding Josef to CC]
>
> On 12.09.2018 01:06, Liu Bo wrote:
> > If metadata space is hungry, how fast flush_space() can run determines
> > the latency we spend in reserve_metadata_space().
> >
> > flush_space()
> > case FLUSH_DELAYED_ITEMS:
> > ...
> > btrfs_end_transaction()
> > case ALLOC_CHUNK:
> > ...
> > btrfs_end_transaction()
> >
> > btrfs_end_transaction()
> > btrfs_async_run_delayed_refs()
> > // queue a work to process delayed refs
> > ...
> > if (wait)
> > wait_for_completion()
> >
> > Although processing delayed refs can add to pinned bytes, pinned bytes
> > can only be used after committing transaction, so waiting async in
> > flush_space() doesn't help.
Nack, but just because I get rid of all of this code in my delayed refs rsv
patchset. Thanks,
Josef
prev parent reply other threads:[~2018-09-12 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 22:06 [PATCH] Btrfs: do not wait after queue async work for delaye refs Liu Bo
2018-09-12 7:19 ` Nikolay Borisov
2018-09-12 13:54 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912135423.fgl7gbc5lx447h4n@destiny \
--to=josef@toxicpanda.com \
--cc=bo.liu@linux.alibaba.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).