From: Daniel Kiper <dkiper@net-space.pl>
To: terrelln@fb.com
Cc: grub-devel@gnu.org, kernel-team@fb.com,
David Sterba <dsterba@suse.cz>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: Import kernel zstd
Date: Fri, 21 Sep 2018 20:10:25 +0200 [thread overview]
Message-ID: <20180921181025.GB29978@router-fw-old.i.net-space.pl> (raw)
In-Reply-To: <20180828013654.1627080-2-terrelln@fb.com>
On Mon, Aug 27, 2018 at 06:36:52PM -0700, Nick Terrell wrote:
> Import xxhash and zstd from the upstream kernel as-is. This will not
> compile. The next patch in the series contains all the changes needed to
> make zstd compile in grub. Only the files needed for decompression are
> imported from zstd.
>
> The files are copied from these locations:
> include/linux/{xxhash,zstd}.h
> lib/xxhash.c
> lib/zstd/
First of all, may I ask you to import zstd from original repository
(https://github.com/facebook/zstd) instead of Linux kernel?
Please do not forget to give a commit id and name of the latest patch
in it. If they have stable releases please use the latest one.
Daniel
next prev parent reply other threads:[~2018-09-22 0:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 1:36 [PATCH 0/3] btrfs: Add zstd support to btrfs Nick Terrell
2018-08-28 1:36 ` [PATCH 2/3] btrfs: Patch the kernel zstd Nick Terrell
2018-09-21 18:23 ` Daniel Kiper
2018-08-28 1:36 ` [PATCH 3/3] btrfs: Add zstd support to btrfs Nick Terrell
2018-09-21 18:29 ` Daniel Kiper
2018-09-11 10:23 ` [PATCH 0/3] " David Sterba
2018-09-11 19:48 ` Nick Terrell
[not found] ` <20180828013654.1627080-2-terrelln@fb.com>
2018-09-21 18:10 ` Daniel Kiper [this message]
2018-09-21 18:48 ` [PATCH 1/3] btrfs: Import kernel zstd Nick Terrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921181025.GB29978@router-fw-old.i.net-space.pl \
--to=dkiper@net-space.pl \
--cc=dsterba@suse.cz \
--cc=grub-devel@gnu.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).