From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 827FCC7112A for ; Sun, 14 Oct 2018 17:43:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A9D120645 for ; Sun, 14 Oct 2018 17:43:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Y7FeEXUj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A9D120645 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-btrfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726758AbeJOBZM (ORCPT ); Sun, 14 Oct 2018 21:25:12 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:53296 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbeJOBZM (ORCPT ); Sun, 14 Oct 2018 21:25:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9Wqk/XeMPxTUh7T1elppiUuhyH0J9KEPIzckWb9wGSs=; b=Y7FeEXUjzoMVVYmbA0tRKNTrF GkY1Vhz26Bw/WIrTMwvazWBECtSPdPSE2AhBmWPGmi5RJ3XHke8LPIAKZtBQ0JLMqxPHcJDcuG4MG SEF+GhQ988VFHuTvvF6WQBCDP26C9mc8n2xT0meWzO6b+u6AqFwnUp0Qp7vwut+KYQiUWaXS+fSBi QSjOO7xthfC8A5cyBt2EvP2zj7khS8M2tVUGRWZzO+HJm6x5VhA8XOa7myxP2eYkuKRrsj3gMAQ05 PvfFjF9T/UZiSG66PpPoWbfMIdEnCOr8h1yLC8d3qmq0C76SvtFUgRPG0oeChkMI4/6T3mfMuBtok Vrq0FWTVQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gBkQG-0004Ga-6m; Sun, 14 Oct 2018 17:43:24 +0000 Date: Sun, 14 Oct 2018 10:43:24 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: david@fromorbit.com, sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, Amir Goldstein , linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 18/25] vfs: hide file range comparison function Message-ID: <20181014174324.GC6400@infradead.org> References: <153938912912.8361.13446310416406388958.stgit@magnolia> <153938927103.8361.6327676425188043040.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153938927103.8361.6327676425188043040.stgit@magnolia> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org > +static struct page *vfs_dedupe_get_page(struct inode *inode, loff_t offset) > +{ > + struct address_space *mapping; > + struct page *page; > + pgoff_t n; > + > + n = offset >> PAGE_SHIFT; > + mapping = inode->i_mapping; > + page = read_mapping_page(mapping, n, NULL); > + if (IS_ERR(page)) > + return page; > + if (!PageUptodate(page)) { > + put_page(page); > + return ERR_PTR(-EIO); > + } > + lock_page(page); > + return page; > +} Might be worth to clean ths up a bit while you are at it: +static struct page *vfs_dedupe_get_page(struct inode *inode, loff_t offset) { struct page *page; page = read_mapping_page(inode->i_mapping, offset >> PAGE_SHIFT, NULL); ... Otherwise looks fine: Reviewed-by: Christoph Hellwig