From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E03B1C04AA5 for ; Mon, 15 Oct 2018 15:42:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FB25208B3 for ; Mon, 15 Oct 2018 15:42:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="xqD0EWKy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FB25208B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-btrfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726744AbeJOX2S (ORCPT ); Mon, 15 Oct 2018 19:28:18 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:33934 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726703AbeJOX2S (ORCPT ); Mon, 15 Oct 2018 19:28:18 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9FFct8e062699; Mon, 15 Oct 2018 15:42:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=A+QwyCpVociTHCDR86S7zw162oAlBMlJZ+RbrXMQUGI=; b=xqD0EWKyMpfXpZrc8YDJ99V+9Eb2FwvB0J2S959K58klUlCHBrLECAkcorWOnKNNkIut FTlBZDXoLd3GdYSYFCjW23X2VFR0nL73WX4SvsWBA5znQFhGhalu707xYMww4jYyAISQ 7aJQ7KF8EjHMxdZG1uPi8fjTolPPNSCriXosZroIjoXFYh98Eud9R3mqTdhrLHoIZwdC lhRuJRZlsR4UD+yBc7N+E66gQ8OFh8RJFWpKvtGZdW73d3ky+p5zpaDF+x2aUjVCVokt 5E7A8ba0kcOzLxFgfgNjjjy+38sMLkL7Ovh6SAHyogWVFXVSUHjNoac2tAXaWgS9ifQd Jw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2n39br35ab-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Oct 2018 15:42:14 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w9FFgCNW018295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Oct 2018 15:42:13 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9FFgBmo028418; Mon, 15 Oct 2018 15:42:11 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 15 Oct 2018 08:42:10 -0700 Date: Mon, 15 Oct 2018 08:42:08 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: david@fromorbit.com, sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, Amir Goldstein , linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 11/25] vfs: pass remap flags to generic_remap_file_range_prep Message-ID: <20181015154208.GH28243@magnolia> References: <153938912912.8361.13446310416406388958.stgit@magnolia> <153938921860.8361.1983470639945895613.stgit@magnolia> <20181014173738.GA6400@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181014173738.GA6400@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9047 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=623 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810150140 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sun, Oct 14, 2018 at 10:37:38AM -0700, Christoph Hellwig wrote: > > + bool is_dedupe = (remap_flags & RFR_SAME_DATA); > > Btw, I think the code would be cleaner if we dropped this variable. Ok to both. I'll move up the patch to replace is_dedupe with remap_flags to avoid churning the _touch function too, btw. --D