From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 1/2] btrfs-progs: ctree.h: Deprecate unused limit flags
Date: Tue, 13 Nov 2018 14:09:13 +0800 [thread overview]
Message-ID: <20181113060914.27663-1-wqu@suse.com> (raw)
BTRFS_QGROUP_LIMIT_RSV_RFER/EXCL are never used by btrfs-progs.
And kernel only do the basic assignment but don't really make use of
them.
So deprecate these two flags in btrfs-progs.
Also, add some comment for all the used flags.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
ctree.h | 12 ++++++------
libbtrfsutil/btrfs.h | 12 ++++++------
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/ctree.h b/ctree.h
index 5d9ba3c555f1..1bbc5a2e9dee 100644
--- a/ctree.h
+++ b/ctree.h
@@ -1038,12 +1038,12 @@ struct btrfs_qgroup_info_item {
} __attribute__ ((__packed__));
/* flags definition for qgroup limits */
-#define BTRFS_QGROUP_LIMIT_MAX_RFER (1ULL << 0)
-#define BTRFS_QGROUP_LIMIT_MAX_EXCL (1ULL << 1)
-#define BTRFS_QGROUP_LIMIT_RSV_RFER (1ULL << 2)
-#define BTRFS_QGROUP_LIMIT_RSV_EXCL (1ULL << 3)
-#define BTRFS_QGROUP_LIMIT_RFER_CMPR (1ULL << 4)
-#define BTRFS_QGROUP_LIMIT_EXCL_CMPR (1ULL << 5)
+#define BTRFS_QGROUP_LIMIT_MAX_RFER (1ULL << 0) /* reference (rfer) limit */
+#define BTRFS_QGROUP_LIMIT_MAX_EXCL (1ULL << 1) /* exclusive (excl) limit */
+#define __BTRFS_QGROUP_LIMIT_RSV_RFER (1ULL << 2) /* deprecated */
+#define __BTRFS_QGROUP_LIMIT_RSV_EXCL (1ULL << 3) /* deprecated */
+#define BTRFS_QGROUP_LIMIT_RFER_CMPR (1ULL << 4) /* compressed rfer limit */
+#define BTRFS_QGROUP_LIMIT_EXCL_CMPR (1ULL << 5) /* compressed excl limit */
struct btrfs_qgroup_limit_item {
__le64 flags;
diff --git a/libbtrfsutil/btrfs.h b/libbtrfsutil/btrfs.h
index 1893c5a2172e..4e58a3cd167b 100644
--- a/libbtrfsutil/btrfs.h
+++ b/libbtrfsutil/btrfs.h
@@ -54,12 +54,12 @@ struct btrfs_ioctl_vol_args {
* struct btrfs_qgroup_limit.flags
* struct btrfs_qgroup_limit_item.flags
*/
-#define BTRFS_QGROUP_LIMIT_MAX_RFER (1ULL << 0)
-#define BTRFS_QGROUP_LIMIT_MAX_EXCL (1ULL << 1)
-#define BTRFS_QGROUP_LIMIT_RSV_RFER (1ULL << 2)
-#define BTRFS_QGROUP_LIMIT_RSV_EXCL (1ULL << 3)
-#define BTRFS_QGROUP_LIMIT_RFER_CMPR (1ULL << 4)
-#define BTRFS_QGROUP_LIMIT_EXCL_CMPR (1ULL << 5)
+#define BTRFS_QGROUP_LIMIT_MAX_RFER (1ULL << 0) /* reference (rfer) limit */
+#define BTRFS_QGROUP_LIMIT_MAX_EXCL (1ULL << 1) /* exclusive (excl) limit */
+#define __BTRFS_QGROUP_LIMIT_RSV_RFER (1ULL << 2) /* deprecated */
+#define __BTRFS_QGROUP_LIMIT_RSV_EXCL (1ULL << 3) /* deprecated */
+#define BTRFS_QGROUP_LIMIT_RFER_CMPR (1ULL << 4) /* compressed rfer limit */
+#define BTRFS_QGROUP_LIMIT_EXCL_CMPR (1ULL << 5) /* compressed excl limit */
struct btrfs_qgroup_limit {
__u64 flags;
--
2.19.1
next reply other threads:[~2018-11-13 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 6:09 Qu Wenruo [this message]
2018-11-13 6:09 ` [PATCH 2/2] btrfs-progs: gitignore: Ignore compressed man pages Qu Wenruo
2018-11-13 6:57 ` Qu Wenruo
2018-11-13 9:53 ` [PATCH 1/2] btrfs-progs: ctree.h: Deprecate unused limit flags Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113060914.27663-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).