From: Johannes Thumshirn <jthumshirn@suse.de>
To: David Sterba <dsterba@suse.com>
Cc: Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: [PATCH 6/6] btrfs: unconditionally provide function prototypes from free-space-tree.h
Date: Wed, 14 Nov 2018 14:35:20 +0100 [thread overview]
Message-ID: <20181114133520.16069-7-jthumshirn@suse.de> (raw)
In-Reply-To: <20181114133520.16069-1-jthumshirn@suse.de>
Currently the function prototypes of:
* search_free_space_info()
* convert_free_space_to_bitmaps()
* convert_free_space_to_extents()
* free_space_test_bit()
* __remove_from_free_space_tree()
* __add_to_free_space_tree()
are hidden behind CONFIG_BTRFS_FS_RUN_SANITY_TESTS.
If CONFIG_BTRFS_FS_RUN_SANITY_TESTS is not set, these functions are only
used within free-space-tree.c so technically there would be no need to provide
the function prototypes. But when CONFIG_BTRFS_FS_RUN_SANITY_TESTS they are
also used from tests/free-space-tree-tests.c which explains the need for
the function prototypes and the non-static declaration of the functions.
When compiling with -Wmissing-prototypes and
CONFIG_BTRFS_FS_RUN_SANITY_TESTS=n gcc emits a warning for each of these
functions, so remove the ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS guard to
make the compiler happy when running 'make W=1'.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
fs/btrfs/free-space-tree.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/btrfs/free-space-tree.h b/fs/btrfs/free-space-tree.h
index 3133651d7d70..0f4db2ad68c8 100644
--- a/fs/btrfs/free-space-tree.h
+++ b/fs/btrfs/free-space-tree.h
@@ -27,7 +27,6 @@ int add_to_free_space_tree(struct btrfs_trans_handle *trans,
int remove_from_free_space_tree(struct btrfs_trans_handle *trans,
u64 start, u64 size);
-#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS
struct btrfs_free_space_info *
search_free_space_info(struct btrfs_trans_handle *trans,
struct btrfs_fs_info *fs_info,
@@ -47,6 +46,5 @@ int convert_free_space_to_extents(struct btrfs_trans_handle *trans,
struct btrfs_path *path);
int free_space_test_bit(struct btrfs_block_group_cache *block_group,
struct btrfs_path *path, u64 offset);
-#endif
#endif
--
2.16.4
next prev parent reply other threads:[~2018-11-14 13:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 13:35 [PATCH 0/6] btrfs: fix compiler warning with make W=1 Johannes Thumshirn
2018-11-14 13:35 ` [PATCH 1/6] btrfs: remove unused drop_on_err in btrfs_mkdir() Johannes Thumshirn
2018-11-14 19:29 ` Omar Sandoval
2018-11-14 13:35 ` [PATCH 2/6] btrfs: remove set but not used variable err in btrfs_add_link Johannes Thumshirn
2018-11-14 13:51 ` Nikolay Borisov
2018-11-14 13:35 ` [PATCH 3/6] btrfs: remove unused function btrfs_sysfs_feature_update() Johannes Thumshirn
2018-11-14 19:31 ` Omar Sandoval
2018-11-14 13:35 ` [PATCH 4/6] btrfs: remove unused variable tree in bio_readpage_error() Johannes Thumshirn
2018-11-14 19:32 ` Omar Sandoval
2018-11-14 13:35 ` [PATCH 5/6] btrfs: remove unused variable tree in end_compressed_bio_write() Johannes Thumshirn
2018-11-14 19:33 ` Omar Sandoval
2018-11-14 21:04 ` David Sterba
2018-11-15 8:00 ` Johannes Thumshirn
2018-11-14 13:35 ` Johannes Thumshirn [this message]
2018-11-14 13:52 ` [PATCH 6/6] btrfs: unconditionally provide function prototypes from free-space-tree.h Nikolay Borisov
2018-11-14 13:54 ` Johannes Thumshirn
2018-11-14 19:53 ` David Sterba
2018-11-14 21:05 ` Nikolay Borisov
2018-11-15 0:09 ` David Sterba
2018-11-14 13:50 ` [PATCH 0/6] btrfs: fix compiler warning with make W=1 Nikolay Borisov
2018-11-15 1:30 ` Qu Wenruo
2018-11-15 10:17 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114133520.16069-7-jthumshirn@suse.de \
--to=jthumshirn@suse.de \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).