From: Omar Sandoval <osandov@osandov.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: David Sterba <dsterba@suse.com>,
Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 5/6] btrfs: remove unused variable tree in end_compressed_bio_write()
Date: Wed, 14 Nov 2018 11:33:21 -0800 [thread overview]
Message-ID: <20181114193321.GD4173@vader> (raw)
In-Reply-To: <20181114133520.16069-6-jthumshirn@suse.de>
On Wed, Nov 14, 2018 at 02:35:19PM +0100, Johannes Thumshirn wrote:
> Commit 2922040236f9 (btrfs: Remove extent_io_ops::writepage_end_io_hook)
> removed the indirection to extent_io_ops::writepage_end_io_hook but didn't
> remove the tree variable which then became unused.
>
> Remove 'tree' as well to silence the warning when -Wunused-but-set-variable
> is used to compile btrfs.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> fs/btrfs/compression.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
> index bde8d0487bbb..088570c5dfb8 100644
> --- a/fs/btrfs/compression.c
> +++ b/fs/btrfs/compression.c
> @@ -229,7 +229,6 @@ static noinline void end_compressed_writeback(struct inode *inode,
> */
> static void end_compressed_bio_write(struct bio *bio)
> {
> - struct extent_io_tree *tree;
> struct compressed_bio *cb = bio->bi_private;
> struct inode *inode;
> struct page *page;
> @@ -248,7 +247,6 @@ static void end_compressed_bio_write(struct bio *bio)
> * call back into the FS and do all the end_io operations
> */
> inode = cb->inode;
> - tree = &BTRFS_I(inode)->io_tree;
> cb->compressed_pages[0]->mapping = cb->inode->i_mapping;
> btrfs_writepage_endio_finish_ordered(cb->compressed_pages[0],
> cb->start, cb->start + cb->len - 1, NULL,
> --
> 2.16.4
>
next prev parent reply other threads:[~2018-11-14 19:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 13:35 [PATCH 0/6] btrfs: fix compiler warning with make W=1 Johannes Thumshirn
2018-11-14 13:35 ` [PATCH 1/6] btrfs: remove unused drop_on_err in btrfs_mkdir() Johannes Thumshirn
2018-11-14 19:29 ` Omar Sandoval
2018-11-14 13:35 ` [PATCH 2/6] btrfs: remove set but not used variable err in btrfs_add_link Johannes Thumshirn
2018-11-14 13:51 ` Nikolay Borisov
2018-11-14 13:35 ` [PATCH 3/6] btrfs: remove unused function btrfs_sysfs_feature_update() Johannes Thumshirn
2018-11-14 19:31 ` Omar Sandoval
2018-11-14 13:35 ` [PATCH 4/6] btrfs: remove unused variable tree in bio_readpage_error() Johannes Thumshirn
2018-11-14 19:32 ` Omar Sandoval
2018-11-14 13:35 ` [PATCH 5/6] btrfs: remove unused variable tree in end_compressed_bio_write() Johannes Thumshirn
2018-11-14 19:33 ` Omar Sandoval [this message]
2018-11-14 21:04 ` David Sterba
2018-11-15 8:00 ` Johannes Thumshirn
2018-11-14 13:35 ` [PATCH 6/6] btrfs: unconditionally provide function prototypes from free-space-tree.h Johannes Thumshirn
2018-11-14 13:52 ` Nikolay Borisov
2018-11-14 13:54 ` Johannes Thumshirn
2018-11-14 19:53 ` David Sterba
2018-11-14 21:05 ` Nikolay Borisov
2018-11-15 0:09 ` David Sterba
2018-11-14 13:50 ` [PATCH 0/6] btrfs: fix compiler warning with make W=1 Nikolay Borisov
2018-11-15 1:30 ` Qu Wenruo
2018-11-15 10:17 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114193321.GD4173@vader \
--to=osandov@osandov.com \
--cc=dsterba@suse.com \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).