linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: David Sterba <dsterba@suse.com>
Cc: Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>,
	Johannes Thumshirn <jthumshirn@suse.de>
Subject: [PATCH v2 0/5] btrfs: fix compiler warning with make W=1
Date: Mon, 19 Nov 2018 10:38:12 +0100	[thread overview]
Message-ID: <20181119093817.9291-1-jthumshirn@suse.de> (raw)

This patchset fixes most of the compiler warnings encountered when building
btrfs with make W=1.

There are two more compiler warnings left in raid56.c:
  CC [M]  fs/btrfs/raid56.o
fs/btrfs/raid56.c: In function ‘finish_rmw’:
fs/btrfs/raid56.c:1185:6: warning: variable ‘p_stripe’ set but not used [-Wunused-but-set-variable]
  int p_stripe = -1;
      ^
fs/btrfs/raid56.c: In function ‘finish_parity_scrub’:
fs/btrfs/raid56.c:2343:6: warning: variable ‘p_stripe’ set but not used [-Wunused-but-set-variable]
  int p_stripe = -1;
      ^
but I'm currently unsure how an appropriate fix would look like. As far as I
can tell these variables have always been unused since they have been
introduced.

There are still warnings left emitted by kernel-doc but these are subject to
another patchset, this one only addresses the warnings generated by gcc.

Changes to v1:
* Added Reviews
* Dropped already applied patches 4 + 5
* Added EXPORT_FOR_TESTS + users

Johannes Thumshirn (5):
  btrfs: remove unused drop_on_err in btrfs_mkdir()
  btrfs: remove set but not used variable err in btrfs_add_link
  btrfs: remove unused function btrfs_sysfs_feature_update()
  btrfs: introduce EXPORT_FOR_TESTS macro
  btrfs: use EXPORT_FOR_TESTS for conditionally shared functions

 fs/btrfs/ctree.h                 |  6 ++++++
 fs/btrfs/extent_io.c             | 14 ++------------
 fs/btrfs/extent_io.h             |  7 +++----
 fs/btrfs/free-space-tree.c       |  8 ++++++--
 fs/btrfs/inode.c                 | 16 ++++++----------
 fs/btrfs/sysfs.c                 | 33 ---------------------------------
 fs/btrfs/sysfs.h                 |  2 --
 fs/btrfs/tests/extent-io-tests.c | 10 +++++-----
 8 files changed, 28 insertions(+), 68 deletions(-)

-- 
2.16.4


             reply	other threads:[~2018-11-19  9:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19  9:38 Johannes Thumshirn [this message]
2018-11-19  9:38 ` [PATCH v2 1/5] btrfs: remove unused drop_on_err in btrfs_mkdir() Johannes Thumshirn
2018-11-19  9:38 ` [PATCH v2 2/5] btrfs: remove set but not used variable err in btrfs_add_link Johannes Thumshirn
2018-11-19 14:13   ` David Sterba
2018-11-19  9:38 ` [PATCH v2 3/5] btrfs: remove unused function btrfs_sysfs_feature_update() Johannes Thumshirn
2018-11-19 14:21   ` David Sterba
2018-11-19  9:38 ` [PATCH v2 4/5] btrfs: introduce EXPORT_FOR_TESTS macro Johannes Thumshirn
2018-11-19  9:49   ` Nikolay Borisov
2018-11-19  9:38 ` [PATCH v2 5/5] btrfs: use EXPORT_FOR_TESTS for conditionally shared functions Johannes Thumshirn
2018-11-19  9:50   ` Nikolay Borisov
2018-11-19 14:40 ` [PATCH v2 0/5] btrfs: fix compiler warning with make W=1 David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181119093817.9291-1-jthumshirn@suse.de \
    --to=jthumshirn@suse.de \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).