From: Christoph Hellwig <hch@infradead.org>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Lu Fengqi <lufq.fnst@cn.fujitsu.com>, linux-btrfs@vger.kernel.org
Subject: Re: [RFC PATCH] btrfs: drop file privileges in btrfs_clone_files
Date: Tue, 27 Nov 2018 23:46:25 -0800 [thread overview]
Message-ID: <20181128074625.GA27028@infradead.org> (raw)
In-Reply-To: <3377ecbb-a46b-bd85-10b3-7163535a4332@suse.com>
On Wed, Nov 28, 2018 at 09:44:59AM +0200, Nikolay Borisov wrote:
>
>
> On 28.11.18 г. 5:07 ч., Lu Fengqi wrote:
> > The generic/513 tell that cloning into a file did not strip security
> > privileges (suid, capabilities) like a regular write would.
> >
> > Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
> > ---
> > The xfs and ocfs2 call generic_remap_file_range_prep to drop file
> > privileges, I'm not sure whether btrfs should do the same thing.
>
> Why do you think btrfs shouldn't do the same thing. Looking at
> remap_file_range_prep it seems that btrfs is missing a ton of checks
> that are useful i.e immutable files/aligned offsets etc.
Any chance we could move btrfs over to use remap_file_range_prep so that
all file systems share the exact same checks?
next prev parent reply other threads:[~2018-11-28 7:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 3:07 [RFC PATCH] btrfs: drop file privileges in btrfs_clone_files Lu Fengqi
2018-11-28 7:44 ` Nikolay Borisov
2018-11-28 7:46 ` Christoph Hellwig [this message]
2018-11-28 7:48 ` Nikolay Borisov
2018-11-28 9:24 ` Lu Fengqi
2018-11-28 10:34 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128074625.GA27028@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=lufq.fnst@cn.fujitsu.com \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox