From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH 0/3] Cleanups around btrfs_get_extent_fiemap
Date: Wed, 12 Dec 2018 09:42:31 +0200 [thread overview]
Message-ID: <20181212074234.20613-1-nborisov@suse.com> (raw)
Following a conversation with Johaness this is what fell out. Turns out the
signature of btrfs_get_extent_fiemap is needlessly complext. So the first patch
fixes it by removing the unnecessary arguments. Patch 2 is a bit of a "catch-all"
mainly renaming variables, thus helping recognise what the code does and
refreshing comments and removing one extra if. Finally, patch 3 removes an
assignment making it (at least to me) more clear what context a particular
variable is used in.
This has survived multiple xfstest runs.
Nikolay Borisov (3):
btrfs: Remove unused arguments from btrfs_get_extent_fiemap
btrfs: Refactor btrfs_get_extent_fiemap
btrfs: Remove redundant assignment
fs/btrfs/ctree.h | 3 +-
fs/btrfs/extent_io.c | 3 +-
fs/btrfs/file.c | 3 +-
fs/btrfs/inode.c | 92 +++++++++++++++++++++++---------------------
4 files changed, 51 insertions(+), 50 deletions(-)
--
2.17.1
next reply other threads:[~2018-12-12 7:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 7:42 Nikolay Borisov [this message]
2018-12-12 7:42 ` [PATCH 1/3] btrfs: Remove unused arguments from btrfs_get_extent_fiemap Nikolay Borisov
2018-12-12 9:14 ` Johannes Thumshirn
2018-12-12 7:42 ` [PATCH 2/3] btrfs: Refactor btrfs_get_extent_fiemap Nikolay Borisov
2019-01-04 14:59 ` David Sterba
2018-12-12 7:42 ` [PATCH 3/3] btrfs: Remove redundant assignment Nikolay Borisov
2018-12-12 9:28 ` Johannes Thumshirn
2019-01-04 15:01 ` [PATCH 0/3] Cleanups around btrfs_get_extent_fiemap David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212074234.20613-1-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox