Re: [PATCH 1/7] btrfs: Remove inode argument from async_cow_submit

Anand Jain
2019-01-05T06:03:11Z

On 01/03/2019 04:49 PM, Nikolay Borisov wrote:
> We already pass the async_cow struct that holds a reference to the
> inode. Exploit this fact and remove the extra inode argument. No
> functional changes.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Reviewed-by: Anand Jain <anand.jain@oracle.com>

> ---
> fs/btrfs/inode.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 38c0f385a617..43baca50fba5 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -714,9 +714,9 @@ static void free_async_extent_pages(struct async_extent *async_extent)
> * queued. We walk all the async extents created by compress_file_range
> * and send them down to the disk.
> */
> -static noinline void submit_compressed_extents(struct inode *inode,
> - struct async_cow *async_cow)
> +static noinline void submit_compressed_extents(struct async_cow *async_cow)
> {
> + struct inode *inode = async_cow->inode;
> struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
> struct async_extent *async_extent;
> u64 alloc_hint = 0;
> @@ -1167,7 +1167,7 @@ static noinline void async_cow_submit(struct btrfs_work *work)
> cond_wake_up_nomb(&fs_info->async_submit_wait);
>
> if (async_cow->inode)
> - submit_compressed_extents(async_cow->inode, async_cow);
> + submit_compressed_extents(async_cow);
> }
>
> static noinline void async_cow_free(struct btrfs_work *work)
>