Re: [PATCH 11/15] btrfs: Factor out in_range macro

Johannes Thumshirn
2019-02-04T13:57:26Z

On 30/01/2019 15:50, Nikolay Borisov wrote:
> This is used in more than one places so let's factor it out in ctree.h.
> No functional changes.

You could move this before 9/15 of your series so you don't need to
duplicate the macro in 9/15.

And also (wanted to comment this to 9/15 but OK here as well) the macro
is prone to overflows. Not yet sure what the impact would be apart from
failing the detection if it is in a range or not. If it lives in ctree.h
this fact at least needs documentation, I guess.

Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850