From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH v2 5/6] btrfs: Set iotree only once in submit_compressed_extents
Date: Wed, 20 Feb 2019 17:11:42 +0200 [thread overview]
Message-ID: <20190220151143.19057-6-nborisov@suse.com> (raw)
In-Reply-To: <20190220151143.19057-1-nborisov@suse.com>
The inode never changes so it's sufficient to dereference it and get
the iotree only once, before the execution of the main loop. No
functional changes, only the size of the function is decreased:
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-44 (-44)
Function old new delta
submit_compressed_extents 1240 1196 -44
Total: Before=88476, After=88432, chg -0.05%
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/inode.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index c6ee1863cd20..06408a278200 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -722,7 +722,7 @@ static noinline void submit_compressed_extents(struct async_cow *async_cow)
struct btrfs_key ins;
struct extent_map *em;
struct btrfs_root *root = BTRFS_I(inode)->root;
- struct extent_io_tree *io_tree;
+ struct extent_io_tree *io_tree = &BTRFS_I(inode)->io_tree;
int ret = 0;
again:
@@ -730,9 +730,6 @@ static noinline void submit_compressed_extents(struct async_cow *async_cow)
async_extent = list_entry(async_cow->extents.next,
struct async_extent, list);
list_del(&async_extent->list);
-
- io_tree = &BTRFS_I(inode)->io_tree;
-
retry:
/* did the compression code fall back to uncompressed IO? */
if (!async_extent->pages) {
--
2.17.1
next prev parent reply other threads:[~2019-02-20 15:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 15:11 [PATCH v2 0/6] Compressed path cleanups Nikolay Borisov
2019-02-20 15:11 ` [PATCH v2 1/6] btrfs: Refactor cow_file_range_async Nikolay Borisov
2019-02-20 15:51 ` Johannes Thumshirn
2019-02-20 15:11 ` [PATCH v2 2/6] btrfs: Remove fs_info from struct async_cow Nikolay Borisov
2019-02-20 15:25 ` Johannes Thumshirn
2019-02-20 15:29 ` Nikolay Borisov
2019-02-20 15:11 ` [PATCH v2 3/6] btrfs: Make compress_file_range take only " Nikolay Borisov
2019-02-20 15:27 ` Johannes Thumshirn
2019-02-21 11:55 ` Nikolay Borisov
2019-02-21 13:08 ` Johannes Thumshirn
2019-02-20 15:11 ` [PATCH v2 4/6] btrfs: Replace clear_extent_bit with unlock_extent Nikolay Borisov
2019-02-20 15:29 ` Johannes Thumshirn
2019-02-20 15:11 ` Nikolay Borisov [this message]
2019-02-20 15:33 ` [PATCH v2 5/6] btrfs: Set iotree only once in submit_compressed_extents Johannes Thumshirn
2019-02-20 15:11 ` [PATCH v2 6/6] btrfs: Factor out common extent locking code " Nikolay Borisov
2019-02-20 15:35 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220151143.19057-6-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).