From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: linux-btrfs@vger.kernel.org
Cc: Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: [PATCH 2/3] btrfs: Initialize inode->i_op once in btrfs_symlink
Date: Mon, 25 Feb 2019 13:07:43 -0600 [thread overview]
Message-ID: <20190225190744.21664-2-rgoldwyn@suse.de> (raw)
In-Reply-To: <20190225190744.21664-1-rgoldwyn@suse.de>
From: Goldwyn Rodrigues <rgoldwyn@suse.com>
inode->i_op is initialized multiple times. Perform it once.
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
fs/btrfs/inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 5c349667c761..9b77fe994cbb 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -10140,7 +10140,6 @@ static int btrfs_symlink(struct inode *dir, struct dentry *dentry,
inode->i_op = &btrfs_symlink_inode_operations;
inode_nohighmem(inode);
- inode->i_mapping->a_ops = &btrfs_aops;
inode_set_bytes(inode, name_len);
btrfs_i_size_write(BTRFS_I(inode), name_len);
err = btrfs_update_inode(trans, root, inode);
--
2.16.4
next prev parent reply other threads:[~2019-02-25 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 19:07 [PATCH 1/3] btrfs: Initialize btrfs_io_ctl instead of memsetting it Goldwyn Rodrigues
2019-02-25 19:07 ` Goldwyn Rodrigues [this message]
2019-02-27 15:39 ` [PATCH 2/3] btrfs: Initialize inode->i_op once in btrfs_symlink David Sterba
2019-02-25 19:07 ` [PATCH 3/3] btrfs: Perform locking/unlocking in btrfs_remap_file_range() Goldwyn Rodrigues
2019-02-26 12:08 ` Filipe Manana
2019-02-26 12:57 ` Goldwyn Rodrigues
2019-02-27 14:52 ` David Sterba
2019-02-27 15:06 ` David Sterba
2019-03-25 19:22 ` David Sterba
2019-02-27 15:47 ` [PATCH 1/3] btrfs: Initialize btrfs_io_ctl instead of memsetting it David Sterba
2019-02-27 17:02 ` Goldwyn Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225190744.21664-2-rgoldwyn@suse.de \
--to=rgoldwyn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=rgoldwyn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).