From: fdmanana@kernel.org
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, Filipe Manana <fdmanana@suse.com>
Subject: [PATCH] generic: add test for fsync after shrinking truncate and rename
Date: Mon, 4 Mar 2019 14:06:22 +0000 [thread overview]
Message-ID: <20190304140622.23997-1-fdmanana@kernel.org> (raw)
From: Filipe Manana <fdmanana@suse.com>
Test that if we truncate a file to reduce its size, rename it and then
fsync it, after a power failure the file has a correct size and name.
This test is motivated by a bug found in btrfs, which is fixed by a
patch for the linux kernel titled:
"Btrfs: fix incorrect file size after shrinking truncate and fsync"
This test currently passes on ext4, xfs, f2fs and patched btrfs.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
tests/generic/532 | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++
tests/generic/532.out | 8 +++++++
tests/generic/group | 1 +
3 files changed, 75 insertions(+)
create mode 100755 tests/generic/532
create mode 100644 tests/generic/532.out
diff --git a/tests/generic/532 b/tests/generic/532
new file mode 100755
index 00000000..64992d85
--- /dev/null
+++ b/tests/generic/532
@@ -0,0 +1,66 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2019 SUSE Linux Products GmbH. All Rights Reserved.
+#
+# FS QA Test No. 532
+#
+# Test that if we truncate a file to reduce its size, rename it and then fsync
+# it, after a power failure the file has a correct size and name.
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ _cleanup_flakey
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+. ./common/dmflakey
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+_require_scratch
+_require_dm_target flakey
+
+rm -f $seqres.full
+
+_scratch_mkfs >>$seqres.full 2>&1
+_require_metadata_journaling $SCRATCH_DEV
+_init_flakey
+_mount_flakey
+
+# Create our test file with an initial size of 8000 bytes, then fsync it,
+# followed by a truncate that reduces its size down to 3000 bytes.
+$XFS_IO_PROG -f -c "pwrite -S 0xab 0 8000" \
+ -c "fsync" \
+ -c "truncate 3000" \
+ $SCRATCH_MNT/foo | _filter_xfs_io
+
+# Now rename the file and fsync it again.
+mv $SCRATCH_MNT/foo $SCRATCH_MNT/bar
+$XFS_IO_PROG -c "fsync" $SCRATCH_MNT/bar
+
+# Simulate a power failure and mount the filesystem to check that the file was
+# persisted with the new name and has a size of 3000 bytes.
+_flakey_drop_and_remount
+
+[ -f $SCRATCH_MNT/bar ] || echo "file name 'bar' is missing"
+[ -f $SCRATCH_MNT/foo ] && echo "file name 'foo' still exists"
+
+echo "File content after power failure:"
+od -A d -t x1 $SCRATCH_MNT/bar
+
+_unmount_flakey
+
+status=0
+exit
diff --git a/tests/generic/532.out b/tests/generic/532.out
new file mode 100644
index 00000000..554fbe2a
--- /dev/null
+++ b/tests/generic/532.out
@@ -0,0 +1,8 @@
+QA output created by 532
+wrote 8000/8000 bytes at offset 0
+XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+File content after power failure:
+0000000 ab ab ab ab ab ab ab ab ab ab ab ab ab ab ab ab
+*
+0002992 ab ab ab ab ab ab ab ab
+0003000
diff --git a/tests/generic/group b/tests/generic/group
index 31011ac8..7d63f303 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -534,3 +534,4 @@
529 auto quick attr
530 auto quick unlink
531 auto quick unlink
+532 auto quick log
--
2.11.0
next reply other threads:[~2019-03-04 14:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 14:06 fdmanana [this message]
2019-03-04 15:04 ` [PATCH] generic: add test for fsync after shrinking truncate and rename Amir Goldstein
2019-03-04 15:23 ` Filipe Manana
2019-03-04 17:59 ` Amir Goldstein
2019-03-04 22:30 ` Filipe Manana
2019-03-05 5:59 ` Amir Goldstein
2019-03-05 9:26 ` Filipe Manana
2019-03-05 10:51 ` Amir Goldstein
2019-03-05 0:50 ` Dave Chinner
2019-03-05 1:00 ` Dave Chinner
2019-03-05 1:08 ` Vijay Chidambaram
2019-03-05 5:39 ` Amir Goldstein
2019-03-05 22:33 ` Dave Chinner
2019-03-06 7:51 ` Amir Goldstein
2019-03-06 21:48 ` Dave Chinner
2019-03-07 7:52 ` Amir Goldstein
2019-03-07 23:19 ` Jayashree Mohan
2019-03-08 4:35 ` Dave Chinner
2019-03-08 15:11 ` Vijay Chidambaram
2019-03-19 1:13 ` Dave Chinner
2019-03-08 3:46 ` Dave Chinner
2019-03-05 9:26 ` [PATCH v2] " fdmanana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304140622.23997-1-fdmanana@kernel.org \
--to=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).