From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63C00C43381 for ; Tue, 19 Mar 2019 12:51:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C0FC20685 for ; Tue, 19 Mar 2019 12:51:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726573AbfCSMvS (ORCPT ); Tue, 19 Mar 2019 08:51:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:35970 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726007AbfCSMvS (ORCPT ); Tue, 19 Mar 2019 08:51:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9498DAEDF for ; Tue, 19 Mar 2019 12:51:17 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id D3163DA7ED; Tue, 19 Mar 2019 13:52:29 +0100 (CET) Date: Tue, 19 Mar 2019 13:52:29 +0100 From: David Sterba To: Nikolay Borisov Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 1/3] btrfs: Remove unused -EIO assignment in end_bio_extent_readpage Message-ID: <20190319125228.GI3516@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , linux-btrfs@vger.kernel.org References: <20190318154520.4086-1-nborisov@suse.com> <20190318154520.4086-2-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190318154520.4086-2-nborisov@suse.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Mar 18, 2019 at 05:45:18PM +0200, Nikolay Borisov wrote: > In case we hit the error case for a metadata buffer in > end_bio_extent_readpage then 'ret' won't really be checked before it's > written again to. This means the -EIO in this case will never be > checked, just remove it. > > Fixes-coverity-id: 1442513 > Signed-off-by: Nikolay Borisov Reviewed-by: David Sterba