From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH URGENT v1.1 0/2] btrfs-progs: Fix the nobarrier behavior of write
Date: Wed, 27 Mar 2019 17:46:50 +0800 [thread overview]
Message-ID: <20190327094652.16078-1-wqu@suse.com> (raw)
This urgent patchset can be fetched from github:
https://github.com/adam900710/btrfs-progs/tree/flush_super
Which is based on v4.20.2.
Before this patch, btrfs-progs writes to the fs has no barrier at all.
All metadata and superblock are just buffered write, no barrier between
super blocks and metadata writes at all.
No wonder why even clear space cache can cause serious transid
corruption to the originally good fs.
Please merge this fix as soon as possible as I really don't want to see
btrfs-progs corrupting any fs any more.
Changelog:
v1.1:
- Use one line error report other than 2 seperate lines.
Qu Wenruo (2):
btrfs-progs: disk-io: Make super block write error easier to read
btrfs-progs: disk-io: Flush to ensure super block write is FUA
disk-io.c | 56 ++++++++++++++++++++++++++++++++++++++++++++-----------
1 file changed, 45 insertions(+), 11 deletions(-)
--
2.21.0
next reply other threads:[~2019-03-27 9:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 9:46 Qu Wenruo [this message]
2019-03-27 9:46 ` [PATCH URGENT v1.1 1/2] btrfs-progs: disk-io: Make super block write error easier to read Qu Wenruo
2019-03-27 11:34 ` Nikolay Borisov
2019-03-27 9:46 ` [PATCH URGENT v1.1 2/2] btrfs-progs: disk-io: Flush to ensure super block write is FUA Qu Wenruo
2019-03-27 14:07 ` [PATCH URGENT v1.1 0/2] btrfs-progs: Fix the nobarrier behavior of write Adam Borowski
2019-03-27 14:17 ` Hugo Mills
2019-03-27 14:39 ` Qu Wenruo
2019-03-27 14:42 ` Qu Wenruo
2019-03-27 14:48 ` Qu Wenruo
2019-03-31 14:42 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327094652.16078-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox