From: fdmanana@kernel.org
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, Filipe Manana <fdmanana@suse.com>
Subject: [PATCH 6/7] fsstress: allow fsync on directories too
Date: Thu, 28 Mar 2019 18:55:09 +0000 [thread overview]
Message-ID: <20190328185509.29086-1-fdmanana@kernel.org> (raw)
From: Filipe Manana <fdmanana@suse.com>
Currently the fsync function can only be performed against regular files.
Allow it to operate on directories too, to increase test coverage and allow
for chances of finding bugs in a filesystem's implementation of fsync
against directories.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
ltp/fsstress.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index 0fb9e399..bd058c04 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -3460,15 +3460,21 @@ fsync_f(int opno, long r)
pathname_t f;
int fd;
int v;
+ DIR *dir = NULL;
init_pathname(&f);
- if (!get_fname(FT_REGFILE, r, &f, NULL, NULL, &v)) {
+ if (!get_fname(FT_REGFILE | FT_DIRm, r, &f, NULL, NULL, &v)) {
if (v)
printf("%d/%d: fsync - no filename\n", procid, opno);
free_pathname(&f);
return;
}
fd = open_path(&f, O_WRONLY);
+ if (fd < 0 && errno == EISDIR) {
+ dir = opendir_path(&f);
+ if (dir)
+ fd = dirfd(dir);
+ }
e = fd < 0 ? errno : 0;
check_cwd();
if (fd < 0) {
@@ -3476,13 +3482,18 @@ fsync_f(int opno, long r)
printf("%d/%d: fsync - open %s failed %d\n",
procid, opno, f.path, e);
free_pathname(&f);
+ if (dir)
+ closedir(dir);
return;
}
e = fsync(fd) < 0 ? errno : 0;
if (v)
printf("%d/%d: fsync %s %d\n", procid, opno, f.path, e);
free_pathname(&f);
- close(fd);
+ if (dir)
+ closedir(dir);
+ else
+ close(fd);
}
void
--
2.11.0
reply other threads:[~2019-03-28 18:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328185509.29086-1-fdmanana@kernel.org \
--to=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).