* [PATCH 6/7] fsstress: allow fsync on directories too
@ 2019-03-28 18:55 fdmanana
0 siblings, 0 replies; only message in thread
From: fdmanana @ 2019-03-28 18:55 UTC (permalink / raw)
To: fstests; +Cc: linux-btrfs, Filipe Manana
From: Filipe Manana <fdmanana@suse.com>
Currently the fsync function can only be performed against regular files.
Allow it to operate on directories too, to increase test coverage and allow
for chances of finding bugs in a filesystem's implementation of fsync
against directories.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
ltp/fsstress.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index 0fb9e399..bd058c04 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -3460,15 +3460,21 @@ fsync_f(int opno, long r)
pathname_t f;
int fd;
int v;
+ DIR *dir = NULL;
init_pathname(&f);
- if (!get_fname(FT_REGFILE, r, &f, NULL, NULL, &v)) {
+ if (!get_fname(FT_REGFILE | FT_DIRm, r, &f, NULL, NULL, &v)) {
if (v)
printf("%d/%d: fsync - no filename\n", procid, opno);
free_pathname(&f);
return;
}
fd = open_path(&f, O_WRONLY);
+ if (fd < 0 && errno == EISDIR) {
+ dir = opendir_path(&f);
+ if (dir)
+ fd = dirfd(dir);
+ }
e = fd < 0 ? errno : 0;
check_cwd();
if (fd < 0) {
@@ -3476,13 +3482,18 @@ fsync_f(int opno, long r)
printf("%d/%d: fsync - open %s failed %d\n",
procid, opno, f.path, e);
free_pathname(&f);
+ if (dir)
+ closedir(dir);
return;
}
e = fsync(fd) < 0 ? errno : 0;
if (v)
printf("%d/%d: fsync %s %d\n", procid, opno, f.path, e);
free_pathname(&f);
- close(fd);
+ if (dir)
+ closedir(dir);
+ else
+ close(fd);
}
void
--
2.11.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-03-28 18:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-28 18:55 [PATCH 6/7] fsstress: allow fsync on directories too fdmanana
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).