Re: [PATCH 1/2] btrfs: tree-checker: Make write time tree checker verify the content of leaves

David Sterba
2019-04-03T14:12:17Z

On Wed, Apr 03, 2019 at 07:59:18PM +0800, Qu Wenruo wrote:
> Commit "btrfs: Do mandatory tree block check before submitting bio" is
> designed to check leaves contents, just as read time check.
>
> However due to the confusing parameter list, "false" is passed to where
> it is supposed to be "true".

And this seems to invalidate all testing since false->true will do
additional expensive checks. I thought I'd fold the fix to the original
patch but in this case it'd be the wrong thing to do due to the visible
effects of the change.