From: Al Viro <viro@zeniv.linux.org.uk>
To: Radostin Stoyanov <rstoyanov1@gmail.com>
Cc: luisbg@kernel.org, clm@fb.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-aio@kvack.org
Subject: Re: [PATCH] fs: remove trailing whitespace
Date: Sat, 6 Apr 2019 02:18:59 +0100 [thread overview]
Message-ID: <20190406011858.GJ2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190406000723.31111-1-rstoyanov1@gmail.com>
On Sat, Apr 06, 2019 at 01:07:23AM +0100, Radostin Stoyanov wrote:
> $ cd fs/
> $ find . -type f -exec sed --in-place 's/[[:space:]]\+$//' {} \+
>
> Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
No. That's not the way to do that kind of stuff. First, how it
should be done (and that really belongs somewhere in Documentation/):
after having convinced Linus that mechanical change in question needs
to happen, you ask him to run the script in question just before the
-rc1 of the next cycle.
Reason for _not_ doing it as you have: you are creating a pile of
conflicts with any number of development branches in various trees,
for no good reason. It's a bloody bad idea, especially for something
this trivial.
What's more, some of those (and the most heavily affected ones) bear
rather interesting comments:
* This translation table was generated automatically, the
* original table can be download from the Microsoft website.
* (http://www.microsoft.com/typography/unicode/unicodecp.htm)
_If_ it's autogenerated, I'd suggest leaving it alone, or modifying
whatever tool has been used to produce the damn thing. FWIW, the
situation might be even more unpleasant - URL in the comment is
stale. Finding the source actually used is not trivial -
poking on archive.org gives multiple versions of the data
that comment probably refers to.
It would be nice to straighten that mess - as it is, we are
probably not stepping into the section 3 there, but "the arrays
below had been produced by some tool (not included) from some
version(s) of the tables once reachable via links on now-defunct
webpage at $URL" is not a good situation, even if nobody really
gives a damn about those tables...
next parent reply other threads:[~2019-04-06 1:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190406000723.31111-1-rstoyanov1@gmail.com>
2019-04-06 1:18 ` Al Viro [this message]
2019-04-08 16:39 ` [PATCH] fs: remove trailing whitespace David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190406011858.GJ2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=clm@fb.com \
--cc=linux-aio@kvack.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@kernel.org \
--cc=rstoyanov1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).