From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 138F0C282DD for ; Sat, 6 Apr 2019 01:19:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D56A52171F for ; Sat, 6 Apr 2019 01:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726388AbfDFBTE (ORCPT ); Fri, 5 Apr 2019 21:19:04 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:48448 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbfDFBTE (ORCPT ); Fri, 5 Apr 2019 21:19:04 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hCZz1-0006nN-3n; Sat, 06 Apr 2019 01:18:59 +0000 Date: Sat, 6 Apr 2019 02:18:59 +0100 From: Al Viro To: Radostin Stoyanov Cc: luisbg@kernel.org, clm@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-aio@kvack.org Subject: Re: [PATCH] fs: remove trailing whitespace Message-ID: <20190406011858.GJ2217@ZenIV.linux.org.uk> References: <20190406000723.31111-1-rstoyanov1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190406000723.31111-1-rstoyanov1@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sat, Apr 06, 2019 at 01:07:23AM +0100, Radostin Stoyanov wrote: > $ cd fs/ > $ find . -type f -exec sed --in-place 's/[[:space:]]\+$//' {} \+ > > Signed-off-by: Radostin Stoyanov No. That's not the way to do that kind of stuff. First, how it should be done (and that really belongs somewhere in Documentation/): after having convinced Linus that mechanical change in question needs to happen, you ask him to run the script in question just before the -rc1 of the next cycle. Reason for _not_ doing it as you have: you are creating a pile of conflicts with any number of development branches in various trees, for no good reason. It's a bloody bad idea, especially for something this trivial. What's more, some of those (and the most heavily affected ones) bear rather interesting comments: * This translation table was generated automatically, the * original table can be download from the Microsoft website. * (http://www.microsoft.com/typography/unicode/unicodecp.htm) _If_ it's autogenerated, I'd suggest leaving it alone, or modifying whatever tool has been used to produce the damn thing. FWIW, the situation might be even more unpleasant - URL in the comment is stale. Finding the source actually used is not trivial - poking on archive.org gives multiple versions of the data that comment probably refers to. It would be nice to straighten that mess - as it is, we are probably not stepping into the section 3 there, but "the arrays below had been produced by some tool (not included) from some version(s) of the tables once reachable via links on now-defunct webpage at $URL" is not a good situation, even if nobody really gives a damn about those tables...