* Re: [PATCH] fs: remove trailing whitespace
[not found] <20190406000723.31111-1-rstoyanov1@gmail.com>
@ 2019-04-06 1:18 ` Al Viro
2019-04-08 16:39 ` David Sterba
1 sibling, 0 replies; 2+ messages in thread
From: Al Viro @ 2019-04-06 1:18 UTC (permalink / raw)
To: Radostin Stoyanov
Cc: luisbg, clm, linux-fsdevel, linux-kernel, linux-btrfs, linux-aio
On Sat, Apr 06, 2019 at 01:07:23AM +0100, Radostin Stoyanov wrote:
> $ cd fs/
> $ find . -type f -exec sed --in-place 's/[[:space:]]\+$//' {} \+
>
> Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
No. That's not the way to do that kind of stuff. First, how it
should be done (and that really belongs somewhere in Documentation/):
after having convinced Linus that mechanical change in question needs
to happen, you ask him to run the script in question just before the
-rc1 of the next cycle.
Reason for _not_ doing it as you have: you are creating a pile of
conflicts with any number of development branches in various trees,
for no good reason. It's a bloody bad idea, especially for something
this trivial.
What's more, some of those (and the most heavily affected ones) bear
rather interesting comments:
* This translation table was generated automatically, the
* original table can be download from the Microsoft website.
* (http://www.microsoft.com/typography/unicode/unicodecp.htm)
_If_ it's autogenerated, I'd suggest leaving it alone, or modifying
whatever tool has been used to produce the damn thing. FWIW, the
situation might be even more unpleasant - URL in the comment is
stale. Finding the source actually used is not trivial -
poking on archive.org gives multiple versions of the data
that comment probably refers to.
It would be nice to straighten that mess - as it is, we are
probably not stepping into the section 3 there, but "the arrays
below had been produced by some tool (not included) from some
version(s) of the tables once reachable via links on now-defunct
webpage at $URL" is not a good situation, even if nobody really
gives a damn about those tables...
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fs: remove trailing whitespace
[not found] <20190406000723.31111-1-rstoyanov1@gmail.com>
2019-04-06 1:18 ` [PATCH] fs: remove trailing whitespace Al Viro
@ 2019-04-08 16:39 ` David Sterba
1 sibling, 0 replies; 2+ messages in thread
From: David Sterba @ 2019-04-08 16:39 UTC (permalink / raw)
To: Radostin Stoyanov
Cc: viro, luisbg, clm, linux-fsdevel, linux-kernel, linux-btrfs,
linux-aio
On Sat, Apr 06, 2019 at 01:07:23AM +0100, Radostin Stoyanov wrote:
> $ cd fs/
> $ find . -type f -exec sed --in-place 's/[[:space:]]\+$//' {} \+
>
> Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
> ---
> fs/btrfs/qgroup.c | 2 +-
> fs/btrfs/transaction.c | 2 +-
> fs/btrfs/tree-log.c | 2 +-
No whitespace-only patches in btrfs please. New patches with trailing
whitespace suffer some serious eyebrows frowning, but we can live what's
in the tree and clean it eventually with along other changes.
^ permalink raw reply [flat|nested] 2+ messages in thread