From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7DDBC282DD for ; Mon, 8 Apr 2019 08:33:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90C5220880 for ; Mon, 8 Apr 2019 08:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbfDHIdq (ORCPT ); Mon, 8 Apr 2019 04:33:46 -0400 Received: from verein.lst.de ([213.95.11.211]:41228 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725925AbfDHIdq (ORCPT ); Mon, 8 Apr 2019 04:33:46 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id AE68468AA6; Mon, 8 Apr 2019 10:33:33 +0200 (CEST) Date: Mon, 8 Apr 2019 10:33:33 +0200 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Qu Wenruo , linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Omar Sandoval , Christoph Hellwig Subject: Re: [PATCH V2] block: don't use for-inside-for in bio_for_each_segment_all Message-ID: <20190408083333.GA28939@lst.de> References: <20190407085325.9380-1-ming.lei@redhat.com> <20190408061604.GA26364@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408061604.GA26364@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Apr 08, 2019 at 08:16:04AM +0200, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig Actually.. I just noticed the gratious done rename creates a (trivial) conflict in a series I was about to submit for 5.2. Can you respin it without the rename to make everyones life a littler easier?