public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: tree-checker: Allow error injection for tree-checker
Date: Wed, 24 Apr 2019 19:45:07 +0200	[thread overview]
Message-ID: <20190424174507.GF20156@twin.jikos.cz> (raw)
In-Reply-To: <20190424072253.4979-1-wqu@suse.com>

On Wed, Apr 24, 2019 at 03:22:53PM +0800, Qu Wenruo wrote:
> Allowing error injection for btrfs_check_leaf_full() and
> btrfs_check_node() is useful to test the failure path of btrfs write
> time tree check.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Does not compile:

  CC [M]  fs/btrfs/tests/extent-map-tests.o
In file included from fs/btrfs/tree-checker.c:18:
./include/linux/error-injection.h:15:15: error: unknown type name ‘bool’
 static inline bool within_error_injection_list(unsigned long addr)
               ^~~~
./include/linux/error-injection.h: In function ‘within_error_injection_list’:
./include/linux/error-injection.h:17:9: error: ‘false’ undeclared (first use in this function)
  return false;
         ^~~~~
./include/linux/error-injection.h:17:9: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [scripts/Makefile.build:275: fs/btrfs/tree-checker.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1737: fs/btrfs/] Error 2


gcc is 8.3.1

  parent reply	other threads:[~2019-04-24 17:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  7:22 [PATCH] btrfs: tree-checker: Allow error injection for tree-checker Qu Wenruo
2019-04-24 17:32 ` David Sterba
2019-04-24 17:45 ` David Sterba [this message]
2019-04-25  0:30   ` Qu Wenruo
2019-04-25 14:13     ` David Sterba
2019-04-25 14:22       ` Qu Wenruo
2019-04-25 15:13         ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424174507.GF20156@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox