From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB2D9C072A4 for ; Wed, 22 May 2019 08:35:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A77B204EC for ; Wed, 22 May 2019 08:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728802AbfEVIfU (ORCPT ); Wed, 22 May 2019 04:35:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:35022 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728406AbfEVIfU (ORCPT ); Wed, 22 May 2019 04:35:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 865EDAD4F; Wed, 22 May 2019 08:35:19 +0000 (UTC) Date: Wed, 22 May 2019 10:35:18 +0200 From: Johannes Thumshirn To: Nikolay Borisov Cc: David Sterba , Linux BTRFS Mailinglist , Chris Mason , Richard Weinberger , David Gstir Subject: Re: [PATCH v3 11/13] btrfs: directly call into crypto framework for checsumming Message-ID: <20190522083518.GB3776@x250> References: <20190522081910.7689-1-jthumshirn@suse.de> <20190522081910.7689-12-jthumshirn@suse.de> <8452a97a-685d-7cb8-7145-3ad37e8aa385@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8452a97a-685d-7cb8-7145-3ad37e8aa385@suse.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, May 22, 2019 at 11:33:39AM +0300, Nikolay Borisov wrote: > > > @@ -1799,16 +1801,22 @@ static int scrub_checksum_data(struct scrub_block *sblock) > > if (!sblock->pagev[0]->have_csum) > > return 0; > > > > + shash->tfm = fs_info->csum_shash; > > + shash->flags = 0; > > + > > + crypto_shash_init(shash); > > + > > on_disk_csum = sblock->pagev[0]->csum; > > page = sblock->pagev[0]->page; > > buffer = kmap_atomic(page); > > > > + memset(csum, 0xff, btrfs_super_csum_size(sctx->fs_info->super_copy)); > > Is this required? You don't do it in other place like > scrub_checksum_tree_block/scrub_checksum_super/__readpage_endio_check. > If it's not strictly require just drop it. I guess this is a leftover, thanks for spotting it. -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850