From: Johannes Thumshirn <jthumshirn@suse.de>
To: David Sterba <dsterba@suse.com>
Cc: Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>,
Chris Mason <clm@fb.com>, Richard Weinberger <richard@nod.at>,
David Gstir <david@sigma-star.at>,
Nikolay Borisov <nborisov@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: [PATCH v4 01/13] btrfs: use btrfs_csum_data() instead of directly calling crc32c
Date: Mon, 3 Jun 2019 16:58:47 +0200 [thread overview]
Message-ID: <20190603145859.7176-2-jthumshirn@suse.de> (raw)
In-Reply-To: <20190603145859.7176-1-jthumshirn@suse.de>
btrfsic_test_for_metadata() directly calls the crc32c() library function
for calculating the CRC32C checksum, but then uses btrfs_csum_final() to
invert the result.
To ease further refactoring and development around checksumming in BTRFS
convert to calling btrfs_csum_data(), which is a wrapper around crc32c().
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/check-integrity.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
index b0c8094528d1..85774e2fa3e5 100644
--- a/fs/btrfs/check-integrity.c
+++ b/fs/btrfs/check-integrity.c
@@ -1728,7 +1728,7 @@ static int btrfsic_test_for_metadata(struct btrfsic_state *state,
size_t sublen = i ? PAGE_SIZE :
(PAGE_SIZE - BTRFS_CSUM_SIZE);
- crc = crc32c(crc, data, sublen);
+ crc = btrfs_csum_data(data, crc, sublen);
}
btrfs_csum_final(crc, csum);
if (memcmp(csum, h->csum, state->csum_size))
--
2.16.4
next prev parent reply other threads:[~2019-06-03 14:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 14:58 [PATCH v4 00/13] Add support for other checksums Johannes Thumshirn
2019-06-03 14:58 ` Johannes Thumshirn [this message]
2019-06-03 14:58 ` [PATCH v4 02/13] btrfs: resurrect btrfs_crc32c() Johannes Thumshirn
2019-06-03 14:58 ` [PATCH v4 03/13] btrfs: use btrfs_crc32c{,_final}() in for free space cache Johannes Thumshirn
2019-06-03 14:58 ` [PATCH v4 04/13] btrfs: don't assume ordered sums to be 4 bytes Johannes Thumshirn
2019-06-03 14:58 ` [PATCH v4 05/13] btrfs: dont assume compressed_bio " Johannes Thumshirn
2019-06-03 14:58 ` [PATCH v4 06/13] btrfs: format checksums according to type for printing Johannes Thumshirn
2019-06-03 16:13 ` David Sterba
2019-06-03 14:58 ` [PATCH v4 07/13] btrfs: add common checksum type validation Johannes Thumshirn
2019-06-03 14:58 ` [PATCH v4 08/13] btrfs: check for supported superblock checksum type before checksum validation Johannes Thumshirn
2019-06-03 14:58 ` [PATCH v4 09/13] btrfs: Simplify btrfs_check_super_csum() and get rid of size assumptions Johannes Thumshirn
2019-06-03 14:58 ` [PATCH v4 10/13] btrfs: add boilerplate code for directly including the crypto framework Johannes Thumshirn
2019-06-03 16:42 ` David Sterba
2019-06-03 14:58 ` [PATCH v4 11/13] btrfs: directly call into crypto framework for checsumming Johannes Thumshirn
2019-06-03 16:50 ` David Sterba
2019-06-03 14:58 ` [PATCH v4 12/13] btrfs: remove assumption about csum type form btrfs_print_data_csum_error() Johannes Thumshirn
2019-06-03 14:58 ` [PATCH v4 13/13] btrfs: add sha256 as another checksum algorithm Johannes Thumshirn
2019-06-03 18:30 ` [PATCH v4 00/13] Add support for other checksums David Sterba
2019-06-03 19:27 ` John Dorminy
2019-06-04 7:37 ` Johannes Thumshirn
2019-06-04 9:15 ` David Sterba
2019-06-04 9:25 ` David Sterba
2019-06-03 19:56 ` waxhead
2019-06-04 7:41 ` Johannes Thumshirn
2019-06-04 9:30 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603145859.7176-2-jthumshirn@suse.de \
--to=jthumshirn@suse.de \
--cc=clm@fb.com \
--cc=david@sigma-star.at \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox