From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3EE3C28CC3 for ; Tue, 4 Jun 2019 09:14:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C785C21976 for ; Tue, 4 Jun 2019 09:14:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbfFDJOe (ORCPT ); Tue, 4 Jun 2019 05:14:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:60424 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726948AbfFDJOd (ORCPT ); Tue, 4 Jun 2019 05:14:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 272D4AC54; Tue, 4 Jun 2019 09:14:32 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 07C38DA85E; Tue, 4 Jun 2019 11:15:23 +0200 (CEST) Date: Tue, 4 Jun 2019 11:15:23 +0200 From: David Sterba To: Johannes Thumshirn Cc: dsterba@suse.cz, David Sterba , Linux BTRFS Mailinglist , Chris Mason , Richard Weinberger , David Gstir , Nikolay Borisov Subject: Re: [PATCH v4 00/13] Add support for other checksums Message-ID: <20190604091523.GU15290@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Johannes Thumshirn , David Sterba , Linux BTRFS Mailinglist , Chris Mason , Richard Weinberger , David Gstir , Nikolay Borisov References: <20190603145859.7176-1-jthumshirn@suse.de> <20190603183022.GS15290@twin.jikos.cz> <20190604073730.GA4225@x250> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190604073730.GA4225@x250> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Jun 04, 2019 at 09:37:30AM +0200, Johannes Thumshirn wrote: > > Let me summarize the current satus: > > > > for strong hash we have SHA256 and BLAKE2. For the fast hash xxhash and > > murmur3 have been suggested. Let me add XXH3 and xxh128 for now (they're > > not finalized yet). > > I know there's a tendency to not trust FIPS but please let's not completely > rule out FIPS approved algorithms (be it SHA-2 or SHA-3) because we will get > asked to include one sooner or later. That's not about FIPS, but the practical reasons. If it's slow nobody will use it. For example, if a crypto-strong hash is used as a hint for deduplication, this means we'll have to count with it for the additional structures that do the reverse mapping from checksum -> block.