From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE3DC28CC5 for ; Wed, 5 Jun 2019 12:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E4E8206BA for ; Wed, 5 Jun 2019 12:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727702AbfFEMgR (ORCPT ); Wed, 5 Jun 2019 08:36:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:42914 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727663AbfFEMgR (ORCPT ); Wed, 5 Jun 2019 08:36:17 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id DC252AC24 for ; Wed, 5 Jun 2019 12:36:15 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 6C869DA843; Wed, 5 Jun 2019 14:37:07 +0200 (CEST) Date: Wed, 5 Jun 2019 14:37:07 +0200 From: David Sterba To: Johannes Thumshirn Cc: Nikolay Borisov , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 1/3] btrfs: Introduce struct btrfs_io_geometry Message-ID: <20190605123707.GA15290@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Johannes Thumshirn , Nikolay Borisov , linux-btrfs@vger.kernel.org References: <20190603090505.16800-1-nborisov@suse.com> <20190603090505.16800-2-nborisov@suse.com> <20190605073532.GA27972@x250> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190605073532.GA27972@x250> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Jun 05, 2019 at 09:35:33AM +0200, Johannes Thumshirn wrote: > I'd merge this patch into the next one, so you only introduce > btrfs_io_geometry when there are actual users for it. > > But that's personal preference I guess. Yeah 1+2 is a good idea, I'll to that.