From: David Sterba <dsterba@suse.cz>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] btrfs: start readahead also in seed devices
Date: Fri, 7 Jun 2019 15:39:18 +0200 [thread overview]
Message-ID: <20190607133918.GE30187@twin.jikos.cz> (raw)
In-Reply-To: <20190606075444.15481-1-naohiro.aota@wdc.com>
On Thu, Jun 06, 2019 at 04:54:44PM +0900, Naohiro Aota wrote:
> Currently, btrfs does not consult seed devices to start readahead. As a
> result, if readahead zone is added to the seed devices, btrfs_reada_wait()
> indefinitely wait for the reada_ctl to finish.
>
> You can reproduce the hung by modifying btrfs/163 to have larger initial
> file size (e.g. xfs_io pwrite 4M instead of current 256K).
>
> Fixes: 7414a03fbf9e ("btrfs: initial readahead code and prototypes")
> Cc: stable@vger.kernel.org # 3.2+: ce7791ffee1e: Btrfs: fix race between readahead and device replace/removal
> Cc: stable@vger.kernel.org # 3.2+
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Thanks, added to misc-next.
prev parent reply other threads:[~2019-06-07 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 7:54 [PATCH] btrfs: start readahead also in seed devices Naohiro Aota
2019-06-06 11:14 ` Filipe Manana
2019-06-07 2:29 ` Naohiro Aota
2019-06-07 13:39 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607133918.GE30187@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox