From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9211FC31E48 for ; Wed, 12 Jun 2019 10:05:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63D05208CB for ; Wed, 12 Jun 2019 10:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560333951; bh=k4A2pzobBLPXbGTuKkiFRaUB9wIe16jn/DYgJKaaS4c=; h=From:To:Cc:Subject:Date:List-ID:From; b=UB+ClvLXSvvn65XtXs1PaGDUzjxW2MXaqStU3EtNrf21a6pvsR44fEla39b8F3ERA a3JqwdvIcafxuZh4PhFu2cxaoOEHt06MPKf0UTWZMkSgsVXayzlTWsb8wKXtM6t7Oy kRO93LrR+7RGVS7sBwR1i7sbXucErzA1HoM4tQzo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437933AbfFLKFu (ORCPT ); Wed, 12 Jun 2019 06:05:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:58370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437919AbfFLKFu (ORCPT ); Wed, 12 Jun 2019 06:05:50 -0400 Received: from localhost.localdomain (bl8-197-74.dsl.telepac.pt [85.241.197.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA2342080A; Wed, 12 Jun 2019 10:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560333949; bh=k4A2pzobBLPXbGTuKkiFRaUB9wIe16jn/DYgJKaaS4c=; h=From:To:Cc:Subject:Date:From; b=hvvnagZ+rUOggi0Nty7gSqjvT2MJObv8mhIQofsQupeQ4z8vIjvu7jD/Bcd5W8dw+ FDcuJJzruJkL8xwyZIebeAXy3Hw+MdNEwwo9HUkKiOOjLE17uaAbMj92Q1+neKaLZX hXRTaHK3D56HQwhBxr9JjQH5CoBxbo0NzhllBf2s= From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH] btrfs/146: remove unnecessary scratch unmount to avoid test failure Date: Wed, 12 Jun 2019 11:05:44 +0100 Message-Id: <20190612100544.1890-1-fdmanana@kernel.org> X-Mailer: git-send-email 2.11.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Filipe Manana Right at the beginning of the test we are unmonting the scratch device, however at this point the device was never mounted, so the unmount fails with an error message like the following: umount: /home/fdmanana/btrfs-tests/scratch_1: not mounted Which is not expected by the golden output and therefore causes the test to fail. Since the device/mount point was not mounted yet in the test, and since the test framework unmounts the scratch device after each test finishes, just remove the call to _scratch_unmount. Signed-off-by: Filipe Manana --- tests/btrfs/146 | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/btrfs/146 b/tests/btrfs/146 index 8ec3128b..18e2eec0 100755 --- a/tests/btrfs/146 +++ b/tests/btrfs/146 @@ -38,7 +38,6 @@ _require_test_program fsync-err _require_test_program dmerror # bring up dmerror device -_scratch_unmount _dmerror_init # Replace first device with error-test device -- 2.11.0