public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 1/3] btrfs: Remove "recovery" mount option
Date: Wed, 12 Jun 2019 16:58:25 +0200	[thread overview]
Message-ID: <20190612145825.GO3563@twin.jikos.cz> (raw)
In-Reply-To: <20190612063657.21063-2-wqu@suse.com>

On Wed, Jun 12, 2019 at 02:36:55PM +0800, Qu Wenruo wrote:
> Commit 8dcddfa048de ("btrfs: Introduce new mount option usebackuproot to
> replace recovery") deprecates "recovery" mount option in 2016, and it
> has been 3 years, it should be OK to remove "recovery" mount option.

Well, that's what we never know if it's ok o not so the deprecated
options usually stay. Eg. subvolrootid is still there.

3 years might sound a like a long time but there are old kernels that
follow the stable branches so I'd rather derive the time to removal from
that. And eg 4.4 still has the 'recovery' option not among the
deprecated, same 4.9 and 4.14.

Since 4.19 it's deprecated so we'll have to wait until that is EOL,
Dec 2020.

  reply	other threads:[~2019-06-12 14:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12  6:36 [PATCH v3 0/3] btrfs: Introduce new rescue= mount options Qu Wenruo
2019-06-12  6:36 ` [PATCH v3 1/3] btrfs: Remove "recovery" mount option Qu Wenruo
2019-06-12 14:58   ` David Sterba [this message]
2019-06-13  1:25     ` Qu Wenruo
2019-06-12  6:36 ` [PATCH v3 2/3] btrfs: Introduce "rescue=" " Qu Wenruo
2019-06-12 15:09   ` David Sterba
2019-06-13  1:30     ` Qu Wenruo
2019-07-25  6:15       ` Qu Wenruo
2019-06-12  6:36 ` [PATCH v3 3/3] btrfs: Introduce new mount option to skip block group items scan Qu Wenruo
2019-06-12 15:10   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612145825.GO3563@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox