Re: [PATCH 0/5] btrfs-progs: tests: Make 64K page size system happier

David Sterba
2019-07-22T16:48:42Z

On Fri, Jul 05, 2019 at 03:26:46PM +0800, Qu Wenruo wrote:
> Since I got another rockpro64, finally I could do some tests with
> aarch64 64K page size mode. (The first board is working as a NAS for
> a while)
>
> Unsurprisingly there are several false test alerts in btrfs-progs
> selftests.
>
> Although there is no existing CI service based on 64K page sized system,
> we'd better support for 64K page size as it's easier and easier to get
> SBC with good enough aarch64 SoC to compile kernel/btrfs-progs and run
> various tests on them.
>
> The first patch fix a bug which mkfs can't accept any sector size on 64K
> page size system.
>
> The remaining patches enhance test cases to make them work on 64K page
> size system (skip those tests unless kernel support subpage sized sector
> size)
>
> Qu Wenruo (5):
> btrfs-progs: mkfs: Apply the sectorsize user specified on 64k page
> size system
> btrfs-progs: fsck-tests: Check if current kernel can mount fs with
> specified sector size
> btrfs-progs: mkfs-tests: Skip 010-minimal-size if we can't mount with
> 4k sector size
> btrfs-progs: misc-tests: Make test cases work or skipped on 64K page
> size system
> btrfs-progs: convert-tests: Skip tests if kernel doesn't support
> subpage sized sector size

The fix is ok, but the test updates and pre-checks do not seem right to
me. The check_preerq helpers are for binaries and rather simple checks
unlike what the mkfs/mount test for 4k sectors does. I'll reply under
the patches with more specific comments.