From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E9CC76188 for ; Tue, 16 Jul 2019 13:40:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F02E52173B for ; Tue, 16 Jul 2019 13:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733132AbfGPNk5 (ORCPT ); Tue, 16 Jul 2019 09:40:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:35002 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728004AbfGPNk5 (ORCPT ); Tue, 16 Jul 2019 09:40:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A5D96ADA2; Tue, 16 Jul 2019 13:40:56 +0000 (UTC) Date: Tue, 16 Jul 2019 15:40:56 +0200 From: Johannes Thumshirn To: Andy Shevchenko Cc: David Sterba , linux-btrfs@vger.kernel.org Subject: Re: Compilation breakage Message-ID: <20190716134055.GG16644@x250.microfocus.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Jul 16, 2019 at 04:29:27PM +0300, Andy Shevchenko wrote: > On Tue, Jul 16, 2019 at 4:28 PM Andy Shevchenko > wrote: > > > > The following commit broke compilation > > > > commit d5178578bcd461cc79118c7a139882350fe505aa > > Author: Johannes Thumshirn > > Date: Mon Jun 3 16:58:57 2019 +0200 > > > > btrfs: directly call into crypto framework for checksumming > > > > ERROR: "crc32c_impl" [fs/btrfs/btrfs.ko] undefined! > > ERROR: "crc32c" [fs/btrfs/btrfs.ko] undefined! > > > > Obviously if we call directly libcrc32c, we may not remove a dependency. This should already be fixed (there where actually three patches fixing this issue). https://lore.kernel.org/linux-btrfs/1562593403-19545-1-git-send-email-linux@roeck-us.net/ https://lore.kernel.org/linux-btrfs/20190708125134.3741552-1-arnd@arndb.de/ and https://lore.kernel.org/linux-btrfs/20190702143903.49264-1-yuehaibing@huawei.com/ David I thought you staged the one from yuehaibing. Thanks (and sorry for the inconvenience), Johannes -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850