Re: [PATCH v2 1/3] uuid: Add inline helpers to operate on raw buffers

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Tue, Jul 16, 2019 at 05:11:33PM +0200, Christoph Hellwig wrote:
> On Tue, Jul 16, 2019 at 06:04:16PM +0300, Andy Shevchenko wrote:
> > +static inline void guid_copy_from_raw(guid_t *dst, const __u8 *src)
> > +{
> > +	memcpy(dst, (const guid_t *)src, sizeof(guid_t));
> > +}
> > +
> > +static inline void guid_copy_to_raw(__u8 *dst, const guid_t *src)
> > +{
> > +	memcpy((guid_t *)dst, src, sizeof(guid_t));
> > +}
> 
> Maybe import_guid/export_guid is a better name?

Yes, sounds good to me.

> Either way, I don't think we need the casts, and they probably want
> kerneldoc comments describing their use.
> 
> Same for the uuid side.

Got it.

> > +static inline void guid_gen_raw(__u8 *guid)
> > +{
> > +	guid_gen((guid_t *)guid);
> > +}
> > +
> > +static inline void uuid_gen_raw(__u8 *uuid)
> > +{
> > +	uuid_gen((uuid_t *)uuid);
> > +}
> 
> I hate this raw naming.  If people really want to use the generators on
> u8 fields a cast seems more descriptive then hiding it.

This entire patch because of BTRFS maintainers, they didn't want the explicit
casts. Maybe something has been changed, I dunno.

Perhaps, you can sell them the point somehow. (everybody else is using a cast
in the kernel).

-- 
With Best Regards,
Andy Shevchenko