From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Josef Bacik <josef@toxicpanda.com>,
kernel-team@fb.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH][RESEND] btrfs: add a force_chunk_alloc to space_info's sysfs
Date: Fri, 23 Aug 2019 13:32:42 +0200 [thread overview]
Message-ID: <20190823113241.GK2752@twin.jikos.cz> (raw)
In-Reply-To: <e54d6bb1-3bcb-a409-575a-c59b2e5da73d@suse.com>
On Fri, Aug 23, 2019 at 09:35:22AM +0300, Nikolay Borisov wrote:
>
>
> On 22.08.19 г. 22:03 ч., Josef Bacik wrote:
> > In testing various things such as the btrfsck patch to detect over
> > allocation of chunks, empty block group deletion, and balance I've had
> > various ways to force chunk allocations for debug purposes. Add a sysfs
> > file to enable forcing of chunk allocation for the owning space info in
> > order to enable us to add testcases in the future to test these various
> > features easier.
> >
> > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
>
> Since this is really a debugging feature I think it should be gated by
> CONFIG_BTRFS_DEBUG.
I did the per-fs debug directories exactly for that purpose, the patches
have been in misc-next for some time ("btrfs: sysfs: add debugging
exports").
prev parent reply other threads:[~2019-08-23 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 19:03 [PATCH][RESEND] btrfs: add a force_chunk_alloc to space_info's sysfs Josef Bacik
2019-08-23 6:35 ` Nikolay Borisov
2019-08-23 11:32 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823113241.GK2752@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox