From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: David Sterba <dsterba@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] btrfs: use xxhash64 for checksumming
Date: Tue, 27 Aug 2019 01:21:46 +0200 [thread overview]
Message-ID: <20190826232146.GE2752@suse.cz> (raw)
In-Reply-To: <238f4883-ced5-009e-2d77-61f5d4a8e5b8@suse.com>
On Mon, Aug 26, 2019 at 06:38:13PM +0300, Nikolay Borisov wrote:
> nit: I'd name this commit "Add xxhash64 to supported checksum hashes"
>
> Personally, I interpret 'use <some hash> for checksumming' as if you are
> modifying code to use that hash. But in fact you are not, at least not
> in that patch.
It could be percieved as nitpicking, but this kind of feedback is a
check that the author's intentions are understood by someone else. Some
subtleties or nuances can be missed by authors and this is maybe
inevitable when one spends significant time on the code or changelog.
The fresh look and first impression is not possible anymore. But this is
how patches are read when found git log.
In this case I agree with you and the use use of 'use' is a bit
misleading, suggesting that xxhash is now default.
next prev parent reply other threads:[~2019-08-26 23:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 11:48 [PATCH v3 0/4] btrfs: support xxhash64 checksums Johannes Thumshirn
2019-08-26 11:48 ` [PATCH v3 1/4] btrfs: turn checksum type define into a enum Johannes Thumshirn
2019-08-26 11:48 ` [PATCH v3 2/4] btrfs: create structure to encode checksum type and length Johannes Thumshirn
2019-08-28 19:19 ` David Sterba
2019-08-28 19:38 ` David Sterba
2019-08-26 11:48 ` [PATCH v3 3/4] btrfs: use xxhash64 for checksumming Johannes Thumshirn
2019-08-26 15:38 ` Nikolay Borisov
2019-08-26 23:21 ` David Sterba [this message]
2019-08-27 7:27 ` Johannes Thumshirn
2019-08-26 11:48 ` [PATCH v3 4/4] btrfs: sysfs: export supported checksums Johannes Thumshirn
2019-08-26 15:39 ` [PATCH v3 0/4] btrfs: support xxhash64 checksums Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826232146.GE2752@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox