Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: Make btrfs_find_name_in_backref return btrfs_inode_ref struct
Date: Tue, 27 Aug 2019 16:13:41 +0200	[thread overview]
Message-ID: <20190827141341.GJ2752@twin.jikos.cz> (raw)
In-Reply-To: <20190827114630.2425-2-nborisov@suse.com>

On Tue, Aug 27, 2019 at 02:46:28PM +0300, Nikolay Borisov wrote:
>  			ret = btrfs_find_name_in_backref(log_eb, log_slot, name,
> -							 namelen, NULL);
> +							 namelen) != NULL;

Isn't there a less confusing and obscure way to do that?

  reply	other threads:[~2019-08-27 14:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 11:46 [PATCH 0/3] Cleanup btrfs_find_name_in* functions Nikolay Borisov
2019-08-27 11:46 ` [PATCH 1/3] btrfs: Make btrfs_find_name_in_backref return btrfs_inode_ref struct Nikolay Borisov
2019-08-27 14:13   ` David Sterba [this message]
2019-08-27 15:45     ` David Sterba
2019-08-27 11:46 ` [PATCH 2/3] btrfs: Make btrfs_find_name_in_ext_backref return struct btrfs_inode_extref Nikolay Borisov
2019-08-27 15:53   ` David Sterba
2019-08-27 11:46 ` [PATCH 3/3] btrfs: Use btrfs_find_name_in_backref in backref_in_log Nikolay Borisov
2019-08-27 16:03   ` David Sterba
2019-08-27 16:04 ` [PATCH 0/3] Cleanup btrfs_find_name_in* functions David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827141341.GJ2752@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox