Re: [PATCH v2 09/11] btrfs-progs: add xxhash sources

[David Sterba <dsterba@suse.cz>]

On Tue, Aug 27, 2019 at 04:05:57PM +0300, Nikolay Borisov wrote:
> 
> 
> On 26.08.19 г. 14:48 ч., Johannes Thumshirn wrote:
> > From: David Sterba <dsterba@suse.com>
> > 
> > git://github.com/Cyan4973/xxHash
> > 
> > Signed-off-by: David Sterba <dsterba@suse.com>
> > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>> ---
> >  crypto/xxhash.c | 1024 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  crypto/xxhash.h |  445 ++++++++++++++++++++++++
> >  2 files changed, 1469 insertions(+)
> 
> 
> Existing crc32c implementation is under kernel-lib/, whereas the xxhash
> will be under crypto. I think we should have some consistency among the
> various hashes we might be implementing in the future. I don't have
> strong preferences either way. I guess crypto/ makes more sense.

The kernel-lib contains 99%-copies of the kernel files and they're
mostly unrelated. The crc32 files could be moved to crypto/ as we'll
have more than that and xxhash there.

The idea with the local versions of hashes is to provide a fallback
implementations of everything we need but the preferred option will be
linking to some existing crypto library like openssl. So we'll need some
glue code etc. This isn't entirely suitable for kerne-lib.