From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8061C3A5A3 for ; Tue, 27 Aug 2019 16:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CC6C2184D for ; Tue, 27 Aug 2019 16:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727401AbfH0QgQ (ORCPT ); Tue, 27 Aug 2019 12:36:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:32886 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726522AbfH0QgQ (ORCPT ); Tue, 27 Aug 2019 12:36:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7DE5BAC84 for ; Tue, 27 Aug 2019 16:36:15 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id B6C0BDA8D5; Tue, 27 Aug 2019 18:36:38 +0200 (CEST) Date: Tue, 27 Aug 2019 18:36:38 +0200 From: David Sterba To: dsterba@suse.cz, Johannes Thumshirn , David Sterba , Linux BTRFS Mailinglist Subject: Re: [PATCH v2 01/11] btrfs-progs: don't blindly assume crc32c in csum_tree_block_size() Message-ID: <20190827163638.GV2752@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Johannes Thumshirn , David Sterba , Linux BTRFS Mailinglist References: <20190826114853.14860-1-jthumshirn@suse.de> <20190826114853.14860-2-jthumshirn@suse.de> <20190827163302.GU2752@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190827163302.GU2752@twin.jikos.cz> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Aug 27, 2019 at 06:33:02PM +0200, David Sterba wrote: > On Mon, Aug 26, 2019 at 01:48:43PM +0200, Johannes Thumshirn wrote: > > The callers of csum_tree_block_size() blindly assume we're only having > > crc32c as a possible checksum and thus pass in > > btrfs_csum_sizes[BTRFS_CSUM_TYPE_CRC32] for the size argument of > > csum_tree_block_size(). > > > > Signed-off-by: Johannes Thumshirn > > Reviewed-by: Nikolay Borisov > > --- > > mkfs/common.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/mkfs/common.c b/mkfs/common.c > > index caca5e707233..b6e549b19272 100644 > > --- a/mkfs/common.c > > +++ b/mkfs/common.c > > @@ -101,7 +101,7 @@ static int btrfs_create_tree_root(int fd, struct btrfs_mkfs_config *cfg, > > } > > > > /* generate checksum */ > > - csum_tree_block_size(buf, btrfs_csum_sizes[BTRFS_CSUM_TYPE_CRC32], 0); > > + csum_tree_block_size(buf, btrfs_csum_sizes[cfg->csum_type], 0); > > Where is btrfs_mkfs_config::csum_type defined? Aha it's in 8/11.