From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CDF1C49ED6 for ; Wed, 11 Sep 2019 16:42:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9437206CD for ; Wed, 11 Sep 2019 16:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568220153; bh=h2PPNE1MH26MNMfa4X3toj1fWjfFPuCIOtgPUcJ//Ws=; h=From:To:Subject:Date:List-ID:From; b=WtjC1OJDzwLQi6SOnHhmfAdKI+7CuKfFO0ANQ4Gw39fYT3joR/s1yRGXUBms20Dec CqHoxlvAbOysNKIhcsICEa77A8eOBuzryNTHRxwLXyfMWnIcmvVLUrBwiVH4PSreEd 5IB6v3IFdadlOlpNNEEd8Tl6DO30rkB9yNig3xr0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729297AbfIKQmc (ORCPT ); Wed, 11 Sep 2019 12:42:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:38238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728896AbfIKQmb (ORCPT ); Wed, 11 Sep 2019 12:42:31 -0400 Received: from localhost.localdomain (bl8-197-74.dsl.telepac.pt [85.241.197.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BD0820863 for ; Wed, 11 Sep 2019 16:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568220151; bh=h2PPNE1MH26MNMfa4X3toj1fWjfFPuCIOtgPUcJ//Ws=; h=From:To:Subject:Date:From; b=OQZ4rpwkD2+ALDDOyYFVDbRbsn2/Q4IU4cNYt10U1wWd1VgvRVvco1MI5hQsrlQ4N YiDn6heJ+583vax/xcgPEOi4gUtlTUsuEpu1c7mgUj11S1AEFGrkpcS0WVGOY1a9oL 8AxUrVnKYagZBVxh+bdmxgeGClS7Sa5ESX77mKhs= From: fdmanana@kernel.org To: linux-btrfs@vger.kernel.org Subject: [PATCH] Btrfs: fix missing error return if writeback for extent buffer never started Date: Wed, 11 Sep 2019 17:42:28 +0100 Message-Id: <20190911164228.13507-1-fdmanana@kernel.org> X-Mailer: git-send-email 2.11.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Filipe Manana If lock_extent_buffer_for_io() fails, it returns a negative value, but its caller btree_write_cache_pages() ignores such error. This means that a call to flush_write_bio(), from lock_extent_buffer_for_io(), might have failed. We should make btree_write_cache_pages() notice such error values and stop immediatelly, making sure filemap_fdatawrite_range() returns an error to the transaction commit path. A failure from flush_write_bio() should also result in the endio callback end_bio_extent_buffer_writepage() being invoked, which sets the BTRFS_FS_*_ERR bits appropriately, so that there's no risk a transaction or log commit doesn't catch a writeback failure. Signed-off-by: Filipe Manana --- fs/btrfs/extent_io.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 1ff438fd5bc2..13a683da71d2 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -3969,6 +3969,10 @@ int btree_write_cache_pages(struct address_space *mapping, if (!ret) { free_extent_buffer(eb); continue; + } else if (ret < 0) { + done = 1; + free_extent_buffer(eb); + break; } ret = write_one_eb(eb, wbc, &epd); -- 2.11.0