From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] btrfs: ctree: Reduce one indent level for btrfs_search_old_slot()
Date: Mon, 23 Sep 2019 18:32:58 +0200 [thread overview]
Message-ID: <20190923163258.GK2751@twin.jikos.cz> (raw)
In-Reply-To: <20190910074019.23158-3-wqu@suse.com>
On Tue, Sep 10, 2019 at 03:40:18PM +0800, Qu Wenruo wrote:
> Pretty much the same refactor for btrfs_search_slot().
Please write something more sensible than that next time, this changelog
makes sense for a short period of time when the patches are in the
mailing list and the context is obvious, but once the patch is merged
the reference to "same thing as in some funrction" does not help.
next prev parent reply other threads:[~2019-09-23 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 7:40 [PATCH 0/3] Small code style cleanup for ctree.c Qu Wenruo
2019-09-10 7:40 ` [PATCH 1/3] btrfs: ctree: Reduce one indent level for btrfs_search_slot() Qu Wenruo
2019-09-10 7:54 ` Anand Jain
2019-09-10 8:24 ` Nikolay Borisov
2019-09-10 8:31 ` Qu Wenruo
2019-09-10 8:42 ` Nikolay Borisov
2019-09-23 16:09 ` David Sterba
2019-09-10 7:40 ` [PATCH 2/3] btrfs: ctree: Reduce one indent level for btrfs_search_old_slot() Qu Wenruo
2019-09-10 7:58 ` Anand Jain
2019-09-23 16:32 ` David Sterba [this message]
2019-09-10 7:40 ` [PATCH 3/3] btrfs: ctree: Remove stalled comment of setting up path lock Qu Wenruo
2019-09-10 7:51 ` Nikolay Borisov
2019-09-23 16:36 ` [PATCH 0/3] Small code style cleanup for ctree.c David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923163258.GK2751@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox