From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C43ECC32774 for ; Fri, 27 Sep 2019 10:52:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AAEE217D7 for ; Fri, 27 Sep 2019 10:52:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbfI0Kwi (ORCPT ); Fri, 27 Sep 2019 06:52:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:44222 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726144AbfI0Kwi (ORCPT ); Fri, 27 Sep 2019 06:52:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 70F44B159; Fri, 27 Sep 2019 10:52:36 +0000 (UTC) From: Nikolay Borisov To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Nikolay Borisov Subject: [PATCH 1/2] common/rc: Remove special handing of 'dup' argument for btrfs Date: Fri, 27 Sep 2019 13:52:32 +0300 Message-Id: <20190927105233.14926-1-nborisov@suse.com> X-Mailer: git-send-email 2.17.1 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org _scratch_pool_mkfs special cases the command executed when 'dup' option is used when creating a filesystem. This is wrong since 'dup' works for all profiles and number of devices. This bug manifested while exercising btrfs' balance argument combinations test. Signed-off-by: Nikolay Borisov --- common/rc | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/common/rc b/common/rc index 9f2c252e5aa5..1b150cbad2f6 100644 --- a/common/rc +++ b/common/rc @@ -885,13 +885,7 @@ _scratch_pool_mkfs() { case $FSTYP in btrfs) - # if dup profile is in mkfs options call _scratch_mkfs instead - # because dup profile only works with single device - if [[ "$*" =~ dup ]]; then - _scratch_mkfs $* - else - $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV_POOL > /dev/null - fi + $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV_POOL > /dev/null ;; *) echo "_scratch_pool_mkfs is not implemented for $FSTYP" 1>&2 -- 2.7.4